Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][Broker]Reduce PartitionedStats local REST call #16916

Merged
merged 3 commits into from
Aug 7, 2022

Conversation

AnonHxy
Copy link
Contributor

@AnonHxy AnonHxy commented Aug 2, 2022

Motivation

  • Reduce local REST calll for org.apache.pulsar.broker.admin.impl.PersistentTopicsBase#internalGetPartitionedStats

Modifications

  • Call local method if partition is owned by this broker, or call REST api usng internal AdminClient

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@AnonHxy
Copy link
Contributor Author

AnonHxy commented Aug 3, 2022

/pulsarbot run-failure-checks

1 similar comment
@AnonHxy
Copy link
Contributor Author

AnonHxy commented Aug 3, 2022

/pulsarbot run-failure-checks

@AnonHxy
Copy link
Contributor Author

AnonHxy commented Aug 3, 2022

/pulsarbot CI - Build - MacOS / Unit-BROKER_FLAKY Tests (pull_request)

@AnonHxy
Copy link
Contributor Author

AnonHxy commented Aug 4, 2022

@HQebupt @codelipenghui @Jason918 PTAL ~

@AnonHxy
Copy link
Contributor Author

AnonHxy commented Aug 5, 2022

/pulsarbot run-failure-checks

@Technoboy- Technoboy- added the type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages label Aug 7, 2022
@github-actions
Copy link

github-actions bot commented Aug 7, 2022

@AnonHxy Please provide a correct documentation label for your PR.
Instructions see Pulsar Documentation Label Guide.

@Technoboy- Technoboy- added this to the 2.12.0 milestone Aug 7, 2022
@github-actions
Copy link

github-actions bot commented Aug 7, 2022

@AnonHxy Please provide a correct documentation label for your PR.
Instructions see Pulsar Documentation Label Guide.

@Technoboy- Technoboy- merged commit d1cf3cf into apache:master Aug 7, 2022
@Technoboy- Technoboy- modified the milestones: 2.12.0, 2.11.0 Aug 8, 2022
Technoboy- pushed a commit to merlimat/pulsar that referenced this pull request Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/admin doc-label-missing type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants