Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[branch-2.7] Upgrade the BookKeeper version to 4.12.1 #16775

Conversation

hangc0276
Copy link
Contributor

@hangc0276 hangc0276 commented Jul 25, 2022

Motivation

When running bin/bookkeeper shell cookie_update command, we get the following exception.

$ bin/bookkeeper shell cookie_update -h
JMX enabled by default
Exception in thread "main" java.lang.NoSuchMethodError: com.beust.jcommander.JCommander.usage(Ljava/lang/StringBuilder;)V
  at org.apache.bookkeeper.tools.framework.Cli.setupCli(Cli.java:142)
  at org.apache.bookkeeper.tools.framework.Cli.<init>(Cli.java:53)
  at org.apache.bookkeeper.tools.framework.Cli.runCli(Cli.java:243)
  at org.apache.bookkeeper.tools.common.BKCommand.apply(BKCommand.java:64)
  at org.apache.bookkeeper.tools.cli.helpers.BookieShellCommand.runCmd(BookieShellCommand.java:46)
  at org.apache.bookkeeper.bookie.BookieShell.run(BookieShell.java:2235)
  at org.apache.bookkeeper.bookie.BookieShell.main(BookieShell.java:2326)

The reason is that in BookKeeper 4.12.0, it depends on the com.beust. commander version 1.48, however, in Pulsar, we depend on the com.beust. commander version 1.78. The Pulsar depends version overrides the BookKeeper's depends version.

However, com.beust. commander 1.78 version's interface has been changed, which leads to the BookKeeper shell command can't be executed.

In BookKeeper 4.12.1, it upgrades the com.beust. commander version to 1.78 in apache/bookkeeper#2523. So we can upgrade BookKeeper dependency from 4.12.0 to 4.12.1 to solve this bug.

Modification

Upgrade the BookKeeper version from 4.12.0 to 4.12.1

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
ewdurbin Ee Durbin
@hangc0276
Copy link
Contributor Author

/pulsarbot run-failure-checks

1 similar comment
@hangc0276
Copy link
Contributor Author

/pulsarbot run-failure-checks

@Technoboy- Technoboy- added this to the 2.11.0 milestone Jul 27, 2022
@Technoboy- Technoboy- removed this from the 2.11.0 milestone Jul 27, 2022
@Technoboy- Technoboy- changed the title Upgrade the BookKeeper version to 4.12.1 [branch-2.7] Upgrade the BookKeeper version to 4.12.1 Jul 27, 2022
@Technoboy- Technoboy- merged commit e786823 into apache:branch-2.7 Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants