[fix] PulsarLedgerManager: add missed return statement #16607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljmarshall
added
type/bug
michaeljmarshall
requested review from
merlimat,
lhotari,
eolivelli and
codelipenghui
michaeljmarshall
added
area/broker
component/bookkeeper
and removed
component/bookkeeper
labels
dlg99
approved these changes
Jul 14, 2022
merlimat
approved these changes
Jul 14, 2022
|
This should only be relevant for backporting to 2.10 branch. |
merlimat
pushed a commit
that referenced
this pull request
Jul 14, 2022
merlimat
added
cherry-picked/branch-2.10
and removed
release/2.8.4
release/2.9.4
labels
|
@merlimat - makes sense, thanks. |
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 19, 2022
(cherry picked from commit 3d863ae)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I observed the following error log in the bookkeeper:
In looking closer, the error happens because there is a missing return statement after completing a promise.
The bug is cosmetic because the promise is completed with the correct error.
Modifications
Verifying this change
No tests are needed since the effect of this bug is only a confusing log line.
Does this pull request potentially affect one of the following parts:
This is not a breaking change.
Documentation
doc-not-needed