[improve][CI] Remove cmd-line level test retries #16524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodece
approved these changes
Jul 12, 2022
eolivelli
approved these changes
Jul 12, 2022
lhotari
approved these changes
Jul 12, 2022
nicoloboschi
force-pushed
the
remove-retries
branch
from
461dd64 to
ffabe5a
Compare
merlimat
added
area/test
area/build
doc-not-needed
merlimat
approved these changes
Jul 12, 2022
codelipenghui
approved these changes
Jul 13, 2022
codelipenghui
added
the
type/enhancement
codelipenghui
changed the title
wuxuanqicn
pushed a commit
to wuxuanqicn/pulsar
that referenced
this pull request
Jul 14, 2022
nicoloboschi
added a commit
to datastax/pulsar
that referenced
this pull request
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It is common that some tests suite in our CI times out. This is because when a test fails the entire suite is retried from the beginning (max 3 times). (example: https://github.com/apache/pulsar/runs/7281063499?check_suite_focus=true)
The command-line retries may sound helpful in making the CI green for a given pull but they actually hide test failures (that may be flakies or real issues!!).
Another issue is that you can't easily see the failed test and most of the time the quickest solution is just to blindly restart the failed jobs. This is not the correct behaviour and it will make the CI less stable over time.
Modifications
Removed the retry from ALL the test suites
doc-not-needed