Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve][cli] Support getEarliestTimeInBacklog at getPartitionedStats method. #16388

Merged
merged 5 commits into from
Jul 13, 2022
Merged

[improve][cli] Support getEarliestTimeInBacklog at getPartitionedStats method. #16388

merged 5 commits into from
Jul 13, 2022

Conversation

mattisonchao
Copy link
Member

Motivation

Support getEarliestTimeInBacklog at getPartitionedStats method.

Modifications

  • Support getEarliestTimeInBacklog at getPartitionedStats method.

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@mattisonchao
Copy link
Member Author

I've got some problems with my local env. So, I try rely on CI to verify this PR.

@mattisonchao mattisonchao marked this pull request as draft July 5, 2022 02:30
@Technoboy- Technoboy- marked this pull request as ready for review July 5, 2022 02:34
@Technoboy- Technoboy- added this to the 2.11.0 milestone Jul 5, 2022
@Technoboy- Technoboy- changed the title Support getEarliestTimeInBacklog at getPartitionedStats method. [improve][admin] Support getEarliestTimeInBacklog at getPartitionedStats method. Jul 5, 2022
@Technoboy- Technoboy- changed the title [improve][admin] Support getEarliestTimeInBacklog at getPartitionedStats method. [improve][cli] Support getEarliestTimeInBacklog at getPartitionedStats method. Jul 5, 2022
@Technoboy- Technoboy- added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages area/cli doc-not-needed Your PR changes do not impact docs labels Jul 5, 2022
gaoran10
gaoran10 approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@gaoran10 gaoran10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattisonchao mattisonchao merged commit 706bf91 into apache:master Jul 13, 2022
@mattisonchao mattisonchao deleted the support_getEarliestTimeInBacklog branch July 13, 2022 02:41
wuxuanqicn pushed a commit to wuxuanqicn/pulsar that referenced this pull request Jul 14, 2022
@mattisonchao @weimob-wuxuanqi
[improve][cli] Support getEarliestTimeInBacklog at `getPartitionedS…
801628c 
…tats` method. (apache#16388)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Technoboy- Technoboy- Technoboy- approved these changes

@gaoran10 gaoran10 gaoran10 approved these changes

@poorbarcode poorbarcode poorbarcode approved these changes

@codelipenghui codelipenghui Awaiting requested review from codelipenghui

@BewareMyPower BewareMyPower Awaiting requested review from BewareMyPower

@congbobo184 congbobo184 Awaiting requested review from congbobo184

@hangc0276 hangc0276 Awaiting requested review from hangc0276

Assignees

@mattisonchao mattisonchao

Labels
area/cli doc-not-needed Your PR changes do not impact docs type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mattisonchao @Technoboy- @gaoran10 @poorbarcode