[fix][txn] Fix TopicTransactionBuffer ledger apend marker throw ManagedLedgerAlreadyClosedException #16265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edLedgerAlreadyClosedException
congbobo184
added
type/bug
congbobo184
requested review from
Technoboy-,
codelipenghui,
gaoran10,
liangyepianzhou and
mattisonchao
...r/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/TopicTransactionBuffer.java
Show resolved
Hide resolved
codelipenghui
approved these changes
Jul 1, 2022
congbobo184
added
doc-not-needed
liangyepianzhou
approved these changes
Jul 1, 2022
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Jul 5, 2022
…edLedgerAlreadyClosedException (apache#16265) * [fix][txn] Fix TopicTransactionBuffer ledger apend marker throw ManagedLedgerAlreadyClosedException
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 11, 2022
…edLedgerAlreadyClosedException (apache#16265) * [fix][txn] Fix TopicTransactionBuffer ledger apend marker throw ManagedLedgerAlreadyClosedException (cherry picked from commit e616e2c) (cherry picked from commit eba93cf)
wuxuanqicn
pushed a commit
to wuxuanqicn/pulsar
that referenced
this pull request
Jul 14, 2022
…edLedgerAlreadyClosedException (apache#16265) * [fix][txn] Fix TopicTransactionBuffer ledger apend marker throw ManagedLedgerAlreadyClosedException
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
we don't handle append tb transaction marker when the ledger in
WriteFailedthrowManagedLedgerAlreadyClosedException.When ledger in
WriteFailed,we need to close the current ledger and create a new ledger, same as #14738Modifications
change the ledger to the
WriteFailedstate, and it will take automatic recovery, and the commit will be successfulVerifying this change
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Does this pull request introduces a new feature? (yes)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
doc-not-needed