[feature][connector] ElasticSearch Sink: option to output canonical key fields (JSON and Avro) #15426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [feat][elasticsearch-sink] Option to output canonical JSON * style * fix test * style
github-actions
bot
added
the
doc
1 task
Anonymitaet
reviewed
May 5, 2022
momo-jun
reviewed
May 10, 2022
Co-authored-by: momo-jun <[email protected]>
nicoloboschi
added a commit
to datastax/pulsar
that referenced
this pull request
May 10, 2022
) * [feat][elasticsearch-sink] Option to output canonical JSON * style * fix test * style (cherry picked from commit e3a16b7)
|
can you rename your PR? eg. [feature][doc] xx |
nicoloboschi
changed the title
|
@lhotari @dlg99 @eolivelli PTAL |
eolivelli
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In case of the inbound message is structured (Avro or JSON) the fields order may change overtime and there's no fields order guarantee from the Pulsar function framework.
The generated _id field of the document is supposed to be the same regardless the input message key fields order.
Modifications
canonicalKeyFields(boolean, default false) to sort the key fields. Both for JSON and Avro we have to parse and rewrite the entire payload. It may increase the CPU overhead even if the sort is only performed on the keys that MUST be lower to 512 bytes in order to suit in the ElasticSearch _id field.doc