[broker]Optimized namespace-level dispathcRateLimiter update #15315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HQebupt
approved these changes
Apr 25, 2022
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Apr 26, 2022
codelipenghui
added
type/enhancement
AnonHxy
added a commit
to AnonHxy/pulsar
that referenced
this pull request
Jul 25, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Because we have used the
HierarchyTopicPoliciesto store dispatch rate for all levels, there is no need to check topic-level when namespace-level updatingModifications
Remove
getTopicPolicies()inorg.apache.pulsar.broker.service.persistent.PersistentTopic#onPoliciesUpdateVerifying this change
Documentation
no-need-doc(Please explain why)