[Improve][admin|client] AsyncHttpConnector doesn't use the system properties configured #15307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m properties. The AsyncHttpConnector will use the configuration inside this properties http.proxyHost and http.proxyPort It is recommended to use pulsar like this for example: PULSAR_EXTRA_OPTS="-Dhttps.proxyHost=<proxy> -Dhttps.proxyPort=<proxy_port> -Dhttp.proxyHost=<proxy> -Dhttp.proxyPort=<proxy_port>" bin/pulsar-admin tenants list
merlimat
approved these changes
Apr 25, 2022
RobertIndie
approved these changes
Apr 26, 2022
HQebupt
approved these changes
Apr 27, 2022
Technoboy-
approved these changes
Apr 30, 2022
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 23, 2022
…perties configured (apache#15307) (cherry picked from commit ebf2487) (cherry picked from commit cb4e216)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AsyncHttpConnector will use the configuration inside System properties http.proxyHost and http.proxyPort
It is recommended to use pulsar like this for example:
PULSAR_EXTRA_OPTS="-Dhttps.proxyHost= -Dhttps.proxyPort=<proxy_port> -Dhttp.proxyHost= -Dhttp.proxyPort=<proxy_port>" bin/pulsar-admin tenants list
Before this change the execution need to add the org.asynchttpclient.useProxyProperties that it is a little bit complex to find.
PULSAR_EXTRA_OPTS="-Dhttps.proxyHost= -Dhttps.proxyPort=<proxy_port> -Dhttp.proxyHost= -Dhttp.proxyPort=<proxy_port> -Dorg.asynchttpclient.useProxyProperties=true" bin/pulsar-admin tenants list
Motivation
When trying to use a web proxy with the pulsar-admin, the configuration was not taking into account unless the variable: org.asynchttpclient.useProxyProperties=true
With this modification this will be done by default in all the cases where the asynchttpclient is used.
Modifications
Activate in the AsyncHTTPClient to take into account by default the ProxyProperties for the proxy.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
Documentation
Check the box below or label this PR directly.
Need to update docs?
no-need-docThe
(Please explain why)