[fix][loadbalance] Fix wrong unit of NIC speed on linux #15304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gaozhangmin:Thanks for your contribution. For this PR, do we need to update docs? |
gaozhangmin
requested review from
eolivelli and
michaeljmarshall
and removed request for
eolivelli
|
@gaozhangmin:Thanks for providing doc info! |
github-actions
bot
added
doc-not-needed
Jason918
reviewed
Apr 25, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/LinuxInfoUtils.java
Outdated
Show resolved
Hide resolved
gaozhangmin
force-pushed
the
fix-WrongNicSpeedConversionOnLinux
branch
from
874822d to
499c560
Compare
|
@mattisonchao PTAL |
michaeljmarshall
approved these changes
Apr 25, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/LinuxInfoUtils.java
Outdated
Show resolved
Hide resolved
mattisonchao
approved these changes
Apr 25, 2022
|
Not in the scope of this PR, but related, see #15322 |
Technoboy-
added
release/2.9.3
release/2.8.4
release/2.10.1
type/bug
RobertIndie
approved these changes
Apr 26, 2022
|
Hi, @gaozhangmin This PR looks could not cherry-pick to branch-2.9, could you mind pushing the new PR to branch-2.9? |
|
Hi, @gaozhangmin This PR looks could not cherry-pick to branch-2.10, could you mind pushing the new PR to branch-2.10? |
|
@gaozhangmin Could you migrate this PR to branch-2.8? |
|
I will cherry-pick #15770 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15229
Motivation
conversion of NIC bandwidth and tx_bytes rx_bytes is wrong on linux platform.
Modifications
For NIC bandwidth:
1,000 bit/s = 1 kbit/s (one thousand bits per second)
For tx_bytes and rx_bytes, the unit should same with NICLimit , so it should be bytes*8/1000=kbit rather than 8/1024.
Documentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
no-need-doc(Please explain why)
doc(Your PR contains doc changes)
doc-added(Docs have been already added)
doc-not-needed