[Build] Use grpc-bom to align grpc library versions #15234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
added
area/build
doc-not-needed
hezhangjian
approved these changes
Apr 20, 2022
lhotari
requested review from
merlimat,
michaeljmarshall,
eolivelli and
codelipenghui
gaoran10
pushed a commit
that referenced
this pull request
Apr 21, 2022
(cherry picked from commit 081f0d1)
gaoran10
pushed a commit
that referenced
this pull request
Apr 21, 2022
(cherry picked from commit 081f0d1)
lhotari
added a commit
to datastax/pulsar
that referenced
this pull request
Apr 22, 2022
(cherry picked from commit 081f0d1)
lhotari
added a commit
to datastax/pulsar
that referenced
this pull request
Apr 22, 2022
(cherry picked from commit 081f0d1)
|
this pull has not been cherry-picked to 2.10 @gaoran10 |
codelipenghui
pushed a commit
that referenced
this pull request
Apr 28, 2022
(cherry picked from commit 081f0d1)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 28, 2022
(cherry picked from commit 081f0d1)
Jason918
pushed a commit
that referenced
this pull request
Jul 29, 2022
(cherry picked from commit 081f0d1)
Jason918
added
cherry-picked/branch-2.7
2 tasks
Jason918
added a commit
that referenced
this pull request
Jul 31, 2022
* Revert "[fix][proxy] Fix client service url (#16834)" This reverts commit 10b4e99. * Revert "[Build] Use grpc-bom to align grpc library versions (#15234)" This reverts commit 99c93d2. * Revert "upgrade aircompressor to 0.20 (#11790)" This reverts commit 5ad16b6. * Revert "[Branch-2.7] Fixed deadlock on metadata cache missing while doing checkReplication (#12484)" This reverts commit 32fe228. * Revert changes of PersistentTopic#getMessageTTL in #12339. Co-authored-by: JiangHaiting <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There are multiple grpc libraries where the versions should be aligned. It's better to use grpc-bom to achieve this.
An additional motivation is to workaround Maven issues where the Maven build locks up in dependency resolution. The bug is https://issues.apache.org/jira/browse/MNG-5592 ,but that isn't fixed even in Maven 3.8.5 version. The workaround for it was to use BOM for grpc dependencies. I noticed this problem when cherry-picking #15212 to a fork based on branch-2.7 .
Modifications
Use grpc-bom for the dependency management of grpc libraries.