Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve skipping of DNS resolution when creating AuthenticationDataHttp instance #15228

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Apr 20, 2022

Motivation

Modifications

  • use InetSocketAddress.createUnresolved method to prevent unnecessary DNS resolution

…tp instance

- improves solution added in apache#15221
  - It's better to use the JDK provided InetSocketAddress.createUnresolved method
    to prevent unnecessary DNS resolution
@lhotari lhotari added type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use area/broker labels Apr 20, 2022
@lhotari lhotari self-assigned this Apr 20, 2022
@github-actions
Copy link

@lhotari:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

1 similar comment
@github-actions
Copy link

@lhotari:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions
Copy link

@lhotari:Thanks for providing doc info!

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This way is better

+1

@lhotari lhotari merged commit e71b98a into apache:master Apr 20, 2022
lhotari added a commit to datastax/pulsar that referenced this pull request Apr 20, 2022
…tp instance (apache#15228)

- improves solution added in apache#15221
  - It's better to use the JDK provided InetSocketAddress.createUnresolved method
    to prevent unnecessary DNS resolution

(cherry picked from commit e71b98a)
lhotari added a commit to datastax/pulsar that referenced this pull request Apr 21, 2022
…tp instance (apache#15228)

- improves solution added in apache#15221
  - It's better to use the JDK provided InetSocketAddress.createUnresolved method
    to prevent unnecessary DNS resolution

(cherry picked from commit e71b98a)
lhotari added a commit to datastax/pulsar that referenced this pull request Apr 21, 2022
…tp instance (apache#15228)

- improves solution added in apache#15221
  - It's better to use the JDK provided InetSocketAddress.createUnresolved method
    to prevent unnecessary DNS resolution

(cherry picked from commit e71b98a)
@michaeljmarshall
Copy link
Member

LGTM, +1

codelipenghui pushed a commit that referenced this pull request Apr 28, 2022
…tp instance (#15228)

- improves solution added in #15221
  - It's better to use the JDK provided InetSocketAddress.createUnresolved method
    to prevent unnecessary DNS resolution

(cherry picked from commit e71b98a)
@codelipenghui codelipenghui added this to the 2.11.0 milestone Apr 28, 2022
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Apr 28, 2022
…tp instance (apache#15228)

- improves solution added in apache#15221
  - It's better to use the JDK provided InetSocketAddress.createUnresolved method
    to prevent unnecessary DNS resolution

(cherry picked from commit e71b98a)
codelipenghui pushed a commit that referenced this pull request Apr 28, 2022
…tp instance (#15228)

- improves solution added in #15221
  - It's better to use the JDK provided InetSocketAddress.createUnresolved method
    to prevent unnecessary DNS resolution

(cherry picked from commit e71b98a)
@codelipenghui codelipenghui added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Apr 28, 2022
codelipenghui pushed a commit that referenced this pull request Apr 29, 2022
…tp instance (#15228)

- improves solution added in #15221
  - It's better to use the JDK provided InetSocketAddress.createUnresolved method
    to prevent unnecessary DNS resolution

(cherry picked from commit e71b98a)
@codelipenghui codelipenghui added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Apr 29, 2022
Jason918 pushed a commit that referenced this pull request Jul 29, 2022
…tp instance (#15228)

- improves solution added in #15221
  - It's better to use the JDK provided InetSocketAddress.createUnresolved method
    to prevent unnecessary DNS resolution

(cherry picked from commit e71b98a)
@Jason918 Jason918 added cherry-picked/branch-2.7 Archived: 2.7 is end of life release/2.7.5 and removed release/2.7.6 labels Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/broker cherry-picked/branch-2.7 Archived: 2.7 is end of life cherry-picked/branch-2.8 Archived: 2.8 is end of life cherry-picked/branch-2.9 Archived: 2.9 is end of life cherry-picked/branch-2.10 doc-not-needed Your PR changes do not impact docs release/2.7.5 release/2.8.4 release/2.9.3 release/2.10.1 type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants