-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve skipping of DNS resolution when creating AuthenticationDataHttp instance #15228
Conversation
…tp instance - improves solution added in apache#15221 - It's better to use the JDK provided InetSocketAddress.createUnresolved method to prevent unnecessary DNS resolution
@lhotari:Thanks for your contribution. For this PR, do we need to update docs? |
1 similar comment
@lhotari:Thanks for your contribution. For this PR, do we need to update docs? |
@lhotari:Thanks for providing doc info! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This way is better
+1
…tp instance (apache#15228) - improves solution added in apache#15221 - It's better to use the JDK provided InetSocketAddress.createUnresolved method to prevent unnecessary DNS resolution (cherry picked from commit e71b98a)
…tp instance (apache#15228) - improves solution added in apache#15221 - It's better to use the JDK provided InetSocketAddress.createUnresolved method to prevent unnecessary DNS resolution (cherry picked from commit e71b98a)
…tp instance (apache#15228) - improves solution added in apache#15221 - It's better to use the JDK provided InetSocketAddress.createUnresolved method to prevent unnecessary DNS resolution (cherry picked from commit e71b98a)
LGTM, +1 |
…tp instance (apache#15228) - improves solution added in apache#15221 - It's better to use the JDK provided InetSocketAddress.createUnresolved method to prevent unnecessary DNS resolution (cherry picked from commit e71b98a)
Motivation
InetSocketAddress.createUnresolved
methodto prevent unnecessary DNS resolution
Modifications
InetSocketAddress.createUnresolved
method to prevent unnecessary DNS resolution