Support advertised listeners for HTTP and HTTPS services #14839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
type/bug
|
@merlimat:Thanks for your contribution. For this PR, do we need to update docs? |
|
@merlimat do we need to update docs for this PR? |
No need for that. It's just fixing the existing behavior. |
merlimat
added
doc-not-needed
codelipenghui
approved these changes
Mar 26, 2022
merlimat
added a commit
that referenced
this pull request
Mar 28, 2022
merlimat
added a commit
that referenced
this pull request
Mar 28, 2022
codelipenghui
added
cherry-picked/branch-2.9
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
codelipenghui
added a commit
to codelipenghui/incubator-pulsar
that referenced
this pull request
May 17, 2022
…g topic lookup ### Motivation apache#14839 fixes the http lookup with multiple advertised listeners, and the added test is try to verify the advertised listeners with 2 brokers, but the config of the additional broker will not update, so the test get passed. The root cause is we are using the (advertised address + WebService port) to register the broker under the loadbalance path, but while creating the lookup result, we will use the WebService URL to get the data, so we will get `MetadataStoreException$NotFoundException`. ### Modification - Added properties support for ResourceUnit, so that we can carry more information while getting least loaded broker - For creating the lookup result, use the broker znode name to get the broker data if it presents in the ResourceUnit ### Verification No new tests needed, just fix the test that added in apache#14839
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The configuration setting
advertisedListenersallows to specify specific listeners for pulsar and pulsar+ssl protocols, along with other protocol handlers, though it's not currently working when HTTP(s) addresses are specified.