-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Build/Tests] Make the test JVM exit if OOME occurs #14509
Conversation
- OOMEs can make the build to take very long to complete. It's better to fail fast in tests when OOMEs occur.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, good idea!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what happens in case of OOM with this flag ?
is surefire reporting the name of the broker test ?
otherwise it will be very hard to understand why CI failed
The OOME does get logged in surefire report files. IIRC, the error code was 3 for the terminated test JVM. This is visible in the console output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's try
+1
Just created an issue to track the fact that we disabled a test: #14523. |
Here's an explanation and a fix for some of the recent OOMEs in tests: #14524 . |
- OOMEs can make the build to take very long to complete. It's better to fail fast in tests when OOMEs occur.
- OOMEs can make the build to take very long to complete. It's better to fail fast in tests when OOMEs occur. (cherry picked from commit 89a36f9)
Hi @lhotari The 2.10 branch also occurs the OOM exception, so I cherry-picked this PR into the |
Motivation
OOMEs can make the build to take very long to complete or to hang.
It's better to fail fast in tests when OOMEs occur.
example of a build failure where the build hangs: https://github.com/apache/pulsar/runs/5371747143?check_suite_focus=true
Modifications
XX:+ExitOnOutOfMemoryError
to test JVM arguments