Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --illegal-access errors resulting from Google Guice - Pulsar IO, Offloaders and Pulsar SQL - Bump Guice to 5.1.0 #14300

Merged
merged 6 commits into from
Feb 17, 2022

Conversation

nicoloboschi
Copy link
Contributor

@nicoloboschi nicoloboschi commented Feb 15, 2022

Motivation

Follow-up of #13810.

The fixes are exactly the same but for pulsar-io/batch-data-generator and jclouds-shaded

Modifications

  • Upgrade to Guice to 5.1.0 in order to make it compatible w/ JDK17
  • Set the Guice version on parent POM to ensure version consistency across submodules
  • Guice is used in batch-data-generator, data-generator, jclouds offloader, pulsar sql
  • Pulsar SQL - removed guice-multibindings as no more needed

Documentation

  • no-need-doc

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Feb 15, 2022
@nicoloboschi
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

eolivelli
eolivelli previously approved these changes Feb 15, 2022
lhotari
lhotari previously approved these changes Feb 15, 2022
@nicoloboschi nicoloboschi dismissed stale reviews from lhotari and eolivelli via 1ba42c1 February 15, 2022 17:15
@nicoloboschi nicoloboschi changed the title Remove --illegal-access errors resulting from Google Guice - Batch Data Generator connector and jcloud-shaded Remove --illegal-access errors resulting from Google Guice - Pulsar IO, Offloaders and Pulsar SQL - Bump Guice to 5.1.0 Feb 15, 2022
@nicoloboschi
Copy link
Contributor Author

@eolivelli @lhotari PTAL again

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari lhotari merged commit 332eca8 into apache:master Feb 17, 2022
@lhotari
Copy link
Member

lhotari commented Feb 17, 2022

@nicoloboschi Perhaps it would make sense to use guice-bom and import that in dependencyManagement ? That would ensure that Guice versions aren't mixed for possible other Guice sub-components. WDYT? I merged this one already so it would need a new PR if you find it useful.

nicoloboschi added a commit to datastax/pulsar that referenced this pull request Feb 23, 2022
…O, Offloaders and Pulsar SQL - Bump Guice to 5.1.0 (apache#14300)

* Remove --illegal-access errors resulting from Google Guice - Batch Data Generator connector

* and jcloud-shaded

* use dependencyManagement

* fix pulsar-sql

(cherry picked from commit 332eca8)
nicoloboschi added a commit to datastax/pulsar that referenced this pull request Mar 1, 2022
…O, Offloaders and Pulsar SQL - Bump Guice to 5.1.0 (apache#14300)

* Remove --illegal-access errors resulting from Google Guice - Batch Data Generator connector

* and jcloud-shaded

* use dependencyManagement

* fix pulsar-sql

(cherry picked from commit 332eca8)
nicoloboschi added a commit to datastax/pulsar that referenced this pull request Mar 1, 2022
…O, Offloaders and Pulsar SQL - Bump Guice to 5.1.0 (apache#14300)

* Remove --illegal-access errors resulting from Google Guice - Batch Data Generator connector

* and jcloud-shaded

* use dependencyManagement

* fix pulsar-sql

(cherry picked from commit 332eca8)
(cherry picked from commit 7953fed)
Nicklee007 pushed a commit to Nicklee007/pulsar that referenced this pull request Apr 20, 2022
…O, Offloaders and Pulsar SQL - Bump Guice to 5.1.0 (apache#14300)

* Remove --illegal-access errors resulting from Google Guice - Batch Data Generator connector

* and jcloud-shaded

* use dependencyManagement

* fix pulsar-sql
nicoloboschi added a commit to datastax/pulsar that referenced this pull request Apr 28, 2022
…O, Offloaders and Pulsar SQL - Bump Guice to 5.1.0 (apache#14300)

* Remove --illegal-access errors resulting from Google Guice - Batch Data Generator connector

* and jcloud-shaded

* use dependencyManagement

* fix pulsar-sql

(cherry picked from commit 332eca8)
@nicoloboschi nicoloboschi added this to the 2.11.0 milestone May 13, 2022
nicoloboschi added a commit that referenced this pull request May 13, 2022
…O, Offloaders and Pulsar SQL - Bump Guice to 5.1.0 (#14300)

* Remove --illegal-access errors resulting from Google Guice - Batch Data Generator connector

* and jcloud-shaded

* use dependencyManagement

* fix pulsar-sql

(cherry picked from commit 332eca8)
nicoloboschi added a commit that referenced this pull request May 20, 2022
…O, Offloaders and Pulsar SQL - Bump Guice to 5.1.0 (#14300)

* Remove --illegal-access errors resulting from Google Guice - Batch Data Generator connector

* and jcloud-shaded

* use dependencyManagement

* fix pulsar-sql

(cherry picked from commit 332eca8)
nicoloboschi added a commit that referenced this pull request May 20, 2022
…O, Offloaders and Pulsar SQL - Bump Guice to 5.1.0 (#14300)

* Remove --illegal-access errors resulting from Google Guice - Batch Data Generator connector

* and jcloud-shaded

* use dependencyManagement

* fix pulsar-sql

(cherry picked from commit 332eca8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants