[Zookeeper] Enable TCP keepAlive flag on the sockets #12982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- see https://issues.apache.org/jira/browse/ZOOKEEPER-1748 for details - "Setting this to true sets the TCP keepAlive flag on the sockets used by quorum members to perform elections. This will allow for connections between quorum members to remain up when there is network infrastructure that may otherwise break them. Some NATs and firewalls may terminate or lose state for long running or idle connections."
lhotari
added
type/enhancement
ZOOKEEPER-3712 "Some broken network infrastructure may lose the FIN packet that is sent from closing client. These never closed client sockets cause OS resource leak. Enabling this option terminates these zombie sockets by idle check. ... Currently this option is only available when default NIOServerCnxnFactory is used."
lhotari
changed the title
merlimat
approved these changes
Nov 29, 2021
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
* Specify -Dzookeeper.tcpKeepAlive=true in default options for Zookeeper - see https://issues.apache.org/jira/browse/ZOOKEEPER-1748 for details - "Setting this to true sets the TCP keepAlive flag on the sockets used by quorum members to perform elections. This will allow for connections between quorum members to remain up when there is network infrastructure that may otherwise break them. Some NATs and firewalls may terminate or lose state for long running or idle connections." * Enable TCP keepalive for on Zookeeper server for client connections ZOOKEEPER-3712 "Some broken network infrastructure may lose the FIN packet that is sent from closing client. These never closed client sockets cause OS resource leak. Enabling this option terminates these zombie sockets by idle check. ... Currently this option is only available when default NIOServerCnxnFactory is used."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
quorum members to perform elections. This will allow for connections between
quorum members to remain up when there is network infrastructure that may
otherwise break them.
Some NATs and firewalls may terminate or lose state for long running
or idle connections."
These never closed client sockets cause OS resource leak. Enabling this option terminates
these zombie sockets by idle check. ... Currently this option is only available
when default NIOServerCnxnFactory is used."
Modifications
Specify
-Dzookeeper.tcpKeepAlive=true -Dzookeeper.clientTcpKeepAlive=truein default options for Zookeeper (
ZK_OPTSinbin/pulsar)Documentation
no-need-doc