-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Protocol] Add guidance to send CloseProducer before sending Producer… #12948
Merged
eolivelli
merged 1 commit into
apache:master
from
michaeljmarshall:add-note-to-protocol-documentation
Dec 2, 2021
Merged
[Protocol] Add guidance to send CloseProducer before sending Producer… #12948
eolivelli
merged 1 commit into
apache:master
from
michaeljmarshall:add-note-to-protocol-documentation
Dec 2, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in case of client side timeout
github-actions
bot
added
the
doc
Your PR contains doc changes, no matter whether the changes are in markdown or code files.
label
Nov 23, 2021
Anonymitaet
approved these changes
Nov 24, 2021
Anonymitaet
reviewed
Nov 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for adding docs! LGTM from a technical writing perspective.
@codelipenghui can you review it from the technical perspective? Thanks |
1 task
dave2wave
requested review from
eolivelli,
merlimat,
addisonj,
codelipenghui,
sijie,
srkukarni and
lhotari
December 2, 2021 16:44
lhotari
approved these changes
Dec 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
eolivelli
approved these changes
Dec 2, 2021
1 task
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
… in case of client side timeout (apache#12948)
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
doc
Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… in case of client side timeout
Motivation
As discussed on the mailing list here, https://lists.apache.org/thread/tko0z4jg0oq0yf931rbow2zf9fq8wjt1, it is most ideal for the client to send a
CloseProducer
command before sending a subsequentProducer
command when the client timeouts out the originalProducer
request.This PR updates the protocol documentation. I will submit a PR to update the Java client once this PR is merged.
Modifications
Verifying this change
This is just a change to documentation.
Does this pull request potentially affect one of the following parts:
Regarding the change to the wire protocol, this is simply an expansion on a currently ambiguous portion of the protocol. I've discussed this change on the mailing list.
Documentation
doc