Fix log level config for pulsar-admin, pulsar-client and pulsar-perf #12915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Logger.isDebugEnabled will evaluate to true in the default configuration due to apache#7789 change
lhotari
added
type/bug
lhotari
requested review from
merlimat,
eolivelli,
315157973 and
codelipenghui
1 task
eolivelli
approved these changes
Nov 22, 2021
nicoloboschi
approved these changes
Nov 22, 2021
|
The patch works like a charm |
codelipenghui
approved these changes
Nov 22, 2021
hangc0276
approved these changes
Nov 22, 2021
merlimat
approved these changes
Nov 22, 2021
zeo1995
pushed a commit
to zeo1995/pulsar
that referenced
this pull request
Nov 23, 2021
* up/master: [Doc] add explanations for REST (apache#12918) [Doc] add explanations for permissions (apache#12920) Apply executable file permissions to py scripts. (apache#12852) Fix log level config for pulsar-admin, pulsar-client and pulsar-perf (apache#12915) Abstract some common methods to AbstractMetadataStore (apache#12916) Build website using https://pulsar.apache.org (apache#12901)
dlg99
pushed a commit
to dlg99/pulsar
that referenced
this pull request
Nov 23, 2021
…pache#12915) - Logger.isDebugEnabled will evaluate to true in the default configuration due to apache#7789 change
codelipenghui
pushed a commit
that referenced
this pull request
Nov 26, 2021
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
…pache#12915) - Logger.isDebugEnabled will evaluate to true in the default configuration due to apache#7789 change
lhotari
added a commit
that referenced
this pull request
Dec 9, 2021
lhotari
added
cherry-picked/branch-2.9
codelipenghui
pushed a commit
that referenced
this pull request
Dec 11, 2021
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
…pache#12915) - Logger.isDebugEnabled will evaluate to true in the default configuration due to apache#7789 change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Logger.isDebugEnabled will evaluate to true in the default configuration due to #7789 change.
The problem was mitigated for
bin/pulsarscript by #8908 .This PR addressed the issue in
pulsar-admin,pulsar-clientandpulsar-perf.Modifications
Set
pulsar.log.root.levelsystem property toinfoby default and make it configurable withPULSAR_LOG_ROOT_LEVELenvironment variable, in the similar way as it is achieved inbin/pulsar.