Optimize resourcegroup test, make test separately and readable #12531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Shoothzj:Thanks for your contribution. For this PR, do we need to update docs? |
github-actions
bot
added
doc-label-missing
doc-not-needed
|
@Shoothzj:Thanks for providing doc info! |
hezhangjian
force-pushed
the
optimize-resource-group-test-1029
branch
from
72cea3e to
ae9ac9b
Compare
hezhangjian
force-pushed
the
optimize-resource-group-test-1029
branch
from
ae9ac9b to
3bf9f82
Compare
tomscut
reviewed
Oct 30, 2021
pulsar-client-admin-api/src/main/java/org/apache/pulsar/common/policies/data/ResourceGroup.java
Show resolved
Hide resolved
codelipenghui
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I'm working on #12499, need to modify the corresponding tests. But currently, these test files are hard to read.
I want to optimize the tests first
Modifications
Documentation
Need to update docs?
no-need-docJust tests optimize