Handle receiveAsync() failures in MultiTopicsConsumer #11843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
type/bug
merlimat
requested review from
rdhabalia,
jerrypeng,
hangc0276 and
codelipenghui
hangc0276
approved these changes
Aug 31, 2021
eolivelli
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 24, 2021
(cherry picked from commit 9f105d0)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In
MultiTopicsConsumerwe're doing areceiveAsync()operation to transfer messages from the individual consumers into the shared queue, but we're not handling the failure path of the returnedCompletableFuture.This future should in theory never fail, but it fails if there is some bug in the code, as it was the case for #11824.
The main issue is that since we're not handle the future failure path, the exception stack traces are completely hidden, making debugging such issues more complicated.
Modification