fix seek at batchIndex level receive duplicated messages #11826
Merged
+91
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
|
@hangc0276 @BewareMyPower PTAL |
BewareMyPower
requested review from
eolivelli,
codelipenghui and
wolfstudy
and removed request for
eolivelli and
codelipenghui
BewareMyPower
added
area/broker
type/bug
BewareMyPower
approved these changes
Aug 30, 2021
codelipenghui
approved these changes
Sep 2, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Sep 9, 2021
Fixes #11825 ### Motivation If AcknowledgmentAtBatchIndexLevelEnabled, consumer may receive duplicated messages after seek to batchIndex. This pull request tries to resolve this problem. ### Modifications Set the `duringSeek` before reveived seek response. ### Verifying this change This change added tests and can be verified as follows: SubscriptionSeekTest.testSeekForBatchMessageAndSpecifiedBatchIndex (cherry picked from commit fe4cd09)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 27, 2021
Fixes apache#11825 ### Motivation If AcknowledgmentAtBatchIndexLevelEnabled, consumer may receive duplicated messages after seek to batchIndex. This pull request tries to resolve this problem. ### Modifications Set the `duringSeek` before reveived seek response. ### Verifying this change This change added tests and can be verified as follows: SubscriptionSeekTest.testSeekForBatchMessageAndSpecifiedBatchIndex (cherry picked from commit fe4cd09) (cherry picked from commit 6763969)
codelipenghui
pushed a commit
that referenced
this pull request
Dec 11, 2021
Fixes #11825 ### Motivation If AcknowledgmentAtBatchIndexLevelEnabled, consumer may receive duplicated messages after seek to batchIndex. This pull request tries to resolve this problem. ### Modifications Set the `duringSeek` before reveived seek response. ### Verifying this change This change added tests and can be verified as follows: SubscriptionSeekTest.testSeekForBatchMessageAndSpecifiedBatchIndex (cherry picked from commit fe4cd09)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
Fixes apache#11825 ### Motivation If AcknowledgmentAtBatchIndexLevelEnabled, consumer may receive duplicated messages after seek to batchIndex. This pull request tries to resolve this problem. ### Modifications Set the `duringSeek` before reveived seek response. ### Verifying this change This change added tests and can be verified as follows: SubscriptionSeekTest.testSeekForBatchMessageAndSpecifiedBatchIndex
aloyszhang
pushed a commit
to aloyszhang/pulsar
that referenced
this pull request
Aug 5, 2022
…master branch (merge request !25) Squash merge branch 'merge-2.8.1.1' into 'inlong-2.8.1.1' This merge request including two genaral parts. 1. Internal modifies a) introduce TAuth authentaciation and Apache Ranger authenrization b) introduce produce&consume metrics at minute level and support reporter for both local file and ngcp c) add log configurations for local file metric reporter d) add INLONG-RELEASE log which record all internal changes and cherry-picks 2. Cherry-picks fix ttl expiry does not take effect (apache#12266) Fix seek at batchIndex level receive duplicated messages (apache#11826)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11825
Motivation
If AcknowledgmentAtBatchIndexLevelEnabled, consumer may receive duplicated messages after seek to batchIndex.
This pull request tries to resolve this problem.
Modifications
Set the
duringSeekbefore reveived seek response.Verifying this change
This change added tests and can be verified as follows:
SubscriptionSeekTest.testSeekForBatchMessageAndSpecifiedBatchIndex
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
no doc need since it's a bug fix and has nothing to do with configurations or apis.