[Python Schema] Fix redefined Record or Enum in Python schema
#11595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaoran10
requested review from
BewareMyPower,
merlimat,
codelipenghui,
congbobo184,
jiazhai and
sijie
codelipenghui
added
release/2.8.1
type/bug
BewareMyPower
requested changes
Aug 8, 2021
|
Thanks for your contribution. For this PR, do we need to update docs? (The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks) |
|
Could you rebase to master to make sure CI passed? |
I added the |
|
@BewareMyPower thanks! |
BewareMyPower
approved these changes
Aug 9, 2021
gaoran10
force-pushed
the
gaoran/fix-python-schema-redefined-record
branch
from
2866080 to
9487b70
Compare
codelipenghui
approved these changes
Aug 9, 2021
LeBW
pushed a commit
to LeBW/pulsar
that referenced
this pull request
Aug 9, 2021
…#11595) Fixes apache#11533 ### Motivation Refer to issue apache#11533 , currently, if users redefined the same `Record` or `Enum` in `Record`, the schema info isn't reused the defined name, this does not match the Avro schema info format. ### Modifications Add a new method `schema_info(self, defined_names)` in `Record`, `Array`, `Map`, and `Enum`, all defined names will be added in the parameter `defined_names` when users use a defined `Record`, or `Enum`, the schema info will use the name of the defined `Record` or `Enum` as the type.
| @@ -393,6 +413,9 @@ def python_type(self): | |||
| return list | |||
|
|
|||
| def validate_type(self, name, val): | |||
| if val is None: | |||
| return None | |||
There was a problem hiding this comment.
Should return the self.default(), not None automatically
There was a problem hiding this comment.
Good catch, I'll fix this. Thanks
hangc0276
pushed a commit
that referenced
this pull request
Aug 12, 2021
Fixes #11533 ### Motivation Refer to issue #11533 , currently, if users redefined the same `Record` or `Enum` in `Record`, the schema info isn't reused the defined name, this does not match the Avro schema info format. ### Modifications Add a new method `schema_info(self, defined_names)` in `Record`, `Array`, `Map`, and `Enum`, all defined names will be added in the parameter `defined_names` when users use a defined `Record`, or `Enum`, the schema info will use the name of the defined `Record` or `Enum` as the type. (cherry picked from commit d66cdbd)
hangc0276
added
cherry-picked/branch-2.8
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…#11595) Fixes apache#11533 ### Motivation Refer to issue apache#11533 , currently, if users redefined the same `Record` or `Enum` in `Record`, the schema info isn't reused the defined name, this does not match the Avro schema info format. ### Modifications Add a new method `schema_info(self, defined_names)` in `Record`, `Array`, `Map`, and `Enum`, all defined names will be added in the parameter `defined_names` when users use a defined `Record`, or `Enum`, the schema info will use the name of the defined `Record` or `Enum` as the type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11533
Motivation
Refer to issue #11533 , currently, if users redefined the same
RecordorEnuminRecord, the schema info isn't reused the defined name, this does not match the Avro schema info format.Modifications
Add a new method
schema_info(self, defined_names)inRecord,Array,Map, andEnum, all defined names will be added in the parameterdefined_nameswhen users use a definedRecord, orEnum, the schema info will use the name of the definedRecordorEnumas the type.Verifying this change
Add test to verify using same
RecordorEnumin a complexRecord.Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
For committer
For this PR, do we need to update docs?
If yes,
if you update docs in this PR, label this PR with the
doclabel.if you plan to update docs later, label this PR with the
doc-requiredlabel.if you need help on updating docs, create a follow-up issue with the
doc-requiredlabel.If no, label this PR with the
no-need-doclabel and explain why.