Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] OffloadPoliciesImplBuilder missing method and not implements OffloadPolicies.Builder #11453

Merged
merged 2 commits into from
Aug 2, 2021
Merged

[fix] OffloadPoliciesImplBuilder missing method and not implements OffloadPolicies.Builder #11453

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38b4629
org.apache.pulsar.common.policies.data.OffloadPoliciesImplBuilder not…
lifepuzzlefun Jul 25, 2021
d965cc7
Update OffloadPoliciesImpl.java
lifepuzzlefun Jul 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/OffloadPoliciesImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,7 +472,7 @@ private static Object getCompatibleValue(Properties properties, Field field) {
return value((String) object, field);
}

public static class OffloadPoliciesImplBuilder {
public static class OffloadPoliciesImplBuilder implements OffloadPolicies.Builder{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public static class OffloadPoliciesImplBuilder implements OffloadPolicies.Builder{
public static class OffloadPoliciesImplBuilder implements OffloadPolicies.Builder {

private OffloadPoliciesImpl impl = new OffloadPoliciesImpl();

public OffloadPoliciesImplBuilder offloadersDirectory(String offloadersDirectory) {
Expand Down Expand Up @@ -550,6 +550,12 @@ public OffloadPoliciesImplBuilder s3ManagedLedgerOffloadRole(String s3ManagedLed
return this;
}

@Override
public Builder setS3ManagedLedgerOffloadRoleSessionName(String s3ManagedLedgerOffloadRoleSessionName) {
impl.s3ManagedLedgerOffloadRoleSessionName = s3ManagedLedgerOffloadRoleSessionName;
return this;
}

public OffloadPoliciesImplBuilder s3ManagedLedgerOffloadRoleSessionName(String s3ManagedLedgerOffloadRoleSessionName) {
impl.s3ManagedLedgerOffloadRoleSessionName = s3ManagedLedgerOffloadRoleSessionName;
return this;
Expand Down