Remove duplicate check for replicationClusterSet

[Technoboy-]

Motivation

NamespacesBase#internalSetNamespaceReplicationClusters has duplicate codes:

pulsar/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java

Lines 757 to 773 in a6e1a32

	Set<String> clusters = clusters();
	for (String clusterId : replicationClusterSet) {
	if (!clusters.contains(clusterId)) {
	throw new RestException(Status.FORBIDDEN, "Invalid cluster id: " + clusterId);
	}
	validatePeerClusterConflict(clusterId, replicationClusterSet);
	}
	for (String clusterId : replicationClusterSet) {
	if (!clusters.contains(clusterId)) {
	throw new RestException(Status.FORBIDDEN, "Invalid cluster id: " + clusterId);
	}
	validatePeerClusterConflict(clusterId, replicationClusterSet);
	}
	for (String clusterId : replicationClusterSet) {
	validateClusterForTenant(namespaceName.getTenant(), clusterId);
	}

Modifications

Remove the duplicate codes.

For contributor

Small code adjustment, no need to update doc.

[Technoboy-]

/pulsarbot run-failure-checks

[Technoboy-]

/pulsarbot run-failure-checks