[Python Client] Fix handle complex schema #11400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaoran10
requested review from
merlimat,
congbobo184,
315157973,
BewareMyPower,
codelipenghui,
eolivelli and
zymap
|
Thanks for your contribution. For this PR, do we need to update docs? (The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks) |
merlimat
reviewed
Jul 21, 2021
| obj = {} | ||
| for k, v in d.items(): | ||
| if isinstance(v, Record): | ||
| obj[k] = self.encode_dict(v.__dict__) |
There was a problem hiding this comment.
This check could also be don in the _get_serialized_value() method:
def _get_serialized_value(self, x):
if isinstance(x, enum.Enum):
return x.name
elif isinstance(x, Record):
self.encode_dict(x.__dict__)
else:
return xThere was a problem hiding this comment.
I fixed this. PTAL
| @@ -56,15 +57,20 @@ def _get_fields(cls, dct): | |||
|
|
|||
| class Record(with_metaclass(RecordMeta, object)): | |||
|
|
|||
| def __init__(self, default=None, required_default=False, required=False, *args, **kwargs): | |||
| def __init__(self, default=None, required_default=False, required=False, decode=False, *args, **kwargs): | |||
There was a problem hiding this comment.
It's not easy to understand what is the meaning of decode=False|True here. Also these arguments are exposed to the users (eg: marking a field as "required"), do we need to expose this decode too?
There was a problem hiding this comment.
I think this is not necessary, I remove the param decode.
merlimat
approved these changes
Jul 21, 2021
sijie
approved these changes
Jul 22, 2021
codelipenghui
approved these changes
Jul 22, 2021
|
@gaoran10 Please rebase to the master branch to make the CI gets passed. |
gaoran10
force-pushed
the
fix-python-client-complex-schema
branch
from
377a12a to
64a56c0
Compare
Technoboy-
pushed a commit
to Technoboy-/pulsar
that referenced
this pull request
Jul 22, 2021
Fixes apache#7785, apache#11221 ### Motivation Currently, the Pulsar python client couldn't handle complex schema, users using complex schema will encounter errors. ### Modifications Fix AvroSchema encodes and decodes complex schema. Fix JsonSchema decodes complex schema. ### Verifying this change This change added tests and can be verified as follows: - *Encode and decode complex schema data* - *Produce and consume complex schema data*
codelipenghui
pushed a commit
that referenced
this pull request
Jul 23, 2021
Fixes #7785, #11221 ### Motivation Currently, the Pulsar python client couldn't handle complex schema, users using complex schema will encounter errors. ### Modifications Fix AvroSchema encodes and decodes complex schema. Fix JsonSchema decodes complex schema. ### Verifying this change This change added tests and can be verified as follows: - *Encode and decode complex schema data* - *Produce and consume complex schema data* (cherry picked from commit 2370643)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
Fixes apache#7785, apache#11221 ### Motivation Currently, the Pulsar python client couldn't handle complex schema, users using complex schema will encounter errors. ### Modifications Fix AvroSchema encodes and decodes complex schema. Fix JsonSchema decodes complex schema. ### Verifying this change This change added tests and can be verified as follows: - *Encode and decode complex schema data* - *Produce and consume complex schema data*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7785, #11221
Motivation
Currently, the Pulsar python client couldn't handle complex schema, users using complex schema will encounter errors.
Modifications
Fix AvroSchema encodes and decodes complex schema.
Fix JsonSchema decodes complex schema.
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changes