Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Fix boost download link in Dockerfile #11129

Merged
merged 1 commit into from
Jun 28, 2021
Merged

[C++] Fix boost download link in Dockerfile #11129

merged 1 commit into from
Jun 28, 2021

Conversation

sh05
Copy link
Contributor

@sh05 sh05 commented Jun 28, 2021

Motivation

C++ library, boost moved to JFrog.Arifactory from Bintray.com

https://www.boost.org/users/news/boost_has_moved_downloads_to_jfr.html

Modifications

Fix download link in Dockerfiles

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage. yes

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): no
  • The public API: no
  • The schema: no
  • The default values of configurations: no
  • The wire protocol: no
  • The rest endpoints: no
  • The admin cli options: no
  • Anything that affects deployment: no

Documentation

  • Does this pull request introduce a new feature? no

eolivelli
eolivelli approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eolivelli eolivelli added this to the 2.9.0 milestone Jun 28, 2021
@merlimat merlimat merged commit 6c9d7c8 into apache:master Jun 28, 2021
codelipenghui pushed a commit that referenced this pull request Jul 7, 2021
@sh05 @codelipenghui
modify Boost downloads link (#11129)
1671baa 
Co-authored-by: Shogo Nakamoto <[email protected]>
(cherry picked from commit 6c9d7c8)
@codelipenghui codelipenghui added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Jul 7, 2021
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
@sh05 @ciaocloud
modify Boost downloads link (apache#11129)
4c840b0 
Co-authored-by: Shogo Nakamoto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkurihar nkurihar nkurihar approved these changes

@BewareMyPower BewareMyPower BewareMyPower approved these changes

@eolivelli eolivelli eolivelli approved these changes

@merlimat merlimat merlimat approved these changes

Assignees

@sh05 sh05

Labels
cherry-picked/branch-2.8 Archived: 2.8 is end of life release/2.8.1
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.
6 participants
@sh05 @merlimat @eolivelli @BewareMyPower @nkurihar @codelipenghui