[Security] Exclude and remove freebuilder dependency #10869
Merged
+16
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
approved these changes
Jun 9, 2021
aahmed-se
approved these changes
Jun 12, 2021
|
Approved |
sijie
approved these changes
Jun 18, 2021
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
### Motivation [Freebuilder](https://github.com/inferred/FreeBuilder) is an annotation processor used in Bookkeeper's StorageClientSetting interface: https://github.com/apache/bookkeeper/blob/16e8ba772bb5cf4c7546fb559bd9d455d4e42625/stream/clients/java/base/src/main/java/org/apache/bookkeeper/clients/config/StorageClientSettings.java#L27-L33 The annotation processor is only needed at compile time. The Freebuilder library gets flagged as a vulnerable library by Sonatype IQ. This causes Pulsar distribution to be flagged as vulnerable since Freebuilder is a transitive dependency. ### Additional context There's a separate issue in Bookkeeper to change the dependency to optional / compileOnly: apache/bookkeeper#2732 ### Modifications Exclude freebuilder library and replace the code that used shaded dependencies from the freebuilder library.
codelipenghui
pushed a commit
that referenced
this pull request
Jun 25, 2021
### Motivation [Freebuilder](https://github.com/inferred/FreeBuilder) is an annotation processor used in Bookkeeper's StorageClientSetting interface: https://github.com/apache/bookkeeper/blob/16e8ba772bb5cf4c7546fb559bd9d455d4e42625/stream/clients/java/base/src/main/java/org/apache/bookkeeper/clients/config/StorageClientSettings.java#L27-L33 The annotation processor is only needed at compile time. The Freebuilder library gets flagged as a vulnerable library by Sonatype IQ. This causes Pulsar distribution to be flagged as vulnerable since Freebuilder is a transitive dependency. ### Additional context There's a separate issue in Bookkeeper to change the dependency to optional / compileOnly: apache/bookkeeper#2732 ### Modifications Exclude freebuilder library and replace the code that used shaded dependencies from the freebuilder library. (cherry picked from commit 406770c)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
### Motivation [Freebuilder](https://github.com/inferred/FreeBuilder) is an annotation processor used in Bookkeeper's StorageClientSetting interface: https://github.com/apache/bookkeeper/blob/16e8ba772bb5cf4c7546fb559bd9d455d4e42625/stream/clients/java/base/src/main/java/org/apache/bookkeeper/clients/config/StorageClientSettings.java#L27-L33 The annotation processor is only needed at compile time. The Freebuilder library gets flagged as a vulnerable library by Sonatype IQ. This causes Pulsar distribution to be flagged as vulnerable since Freebuilder is a transitive dependency. ### Additional context There's a separate issue in Bookkeeper to change the dependency to optional / compileOnly: apache/bookkeeper#2732 ### Modifications Exclude freebuilder library and replace the code that used shaded dependencies from the freebuilder library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Freebuilder is an annotation processor used in Bookkeeper's StorageClientSetting interface:
https://github.com/apache/bookkeeper/blob/16e8ba772bb5cf4c7546fb559bd9d455d4e42625/stream/clients/java/base/src/main/java/org/apache/bookkeeper/clients/config/StorageClientSettings.java#L27-L33
The annotation processor is only needed at compile time.
The Freebuilder library gets flagged as a vulnerable library by Sonatype IQ. This causes Pulsar distribution to be flagged as vulnerable since Freebuilder is a transitive dependency.
Additional context
There's a separate issue in Bookkeeper to change the dependency to optional / compileOnly: apache/bookkeeper#2732
Modifications
Exclude freebuilder library and replace the code that used shaded dependencies from the freebuilder library.