Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Branch-2.7: Make PrometheusMetricsTest. testAuthMetrics pass on CI #10699

Closed
wants to merge 1 commit into from
Closed

Branch-2.7: Make PrometheusMetricsTest. testAuthMetrics pass on CI #10699

wants to merge 1 commit into from

Conversation

eolivelli
Copy link
Contributor

@eolivelli eolivelli commented May 25, 2021 •
edited
Loading

  • on CI sometimes the tests sees "tls" auth metrics together with "token", depending on the execution order of tests
  • now we verify that token auth is detected and we skip other auth

fixes #10698

@eolivelli
Make PrometheusMetricsTest pass on CI
e49767e 
- on CI sometimes the tests sees tls auth metrics
- now we verify that token auth is detected and we skip other auth
@eolivelli eolivelli self-assigned this May 25, 2021
@eolivelli eolivelli changed the title Make PrometheusMetricsTest pass on CI Branch-2.7: Make PrometheusMetricsTest pass on CI May 25, 2021
@eolivelli eolivelli changed the title Branch-2.7: Make PrometheusMetricsTest pass on CI Branch-2.7: Make PrometheusMetricsTest. testAuthMetrics pass on CI May 25, 2021
@eolivelli eolivelli requested a review from codelipenghui May 25, 2021 12:56
@eolivelli eolivelli closed this Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codelipenghui codelipenghui Awaiting requested review from codelipenghui

Assignees

@eolivelli eolivelli

Labels
release/2.7.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eolivelli