Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2.5.0] Functions dead-letter-topic parameter not supported #6084

Closed
frejonb opened this issue Jan 18, 2020 · 4 comments
Closed

[v2.5.0] Functions dead-letter-topic parameter not supported #6084

frejonb opened this issue Jan 18, 2020 · 4 comments
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. help wanted type/bug The PR fixed a bug or issue reported a bug
Milestone
2.7.0

Comments

@frejonb
Copy link
Contributor

frejonb commented Jan 18, 2020

Describe the bug
In the Functions reference https://pulsar.apache.org/docs/en/functions-cli/ it shows a parameter dead-letter-topic. When using it, it is passed to /pulsar/instances/python-instance/python_instance_main.py under the --function_details json as

"customRuntimeOptions": "persistent://tenant/namespace/dlq-topic"

But customRuntimeOptions is not recognized:

google.protobuf.json_format.ParseError: Message type "proto.FunctionDetails" has no field named "customRuntimeOptions".
 Available Fields(except extensions): ['tenant', 'namespace', 'name', 'className', 'logTopic', 'processingGuarantees', 'userConfig', 'secretsMap', 'runtime', 'autoAck', 'parallelism', 'source', 'sink', 'resources', 'packageUrl', 'retryDetails', 'runtimeFlags', 'componentType']

To Reproduce
Steps to reproduce the behavior:

  1. Create pulsar function with --dead-letter-topic argument

Expected behavior
Function should be configured correctly

Desktop (please complete the following information):

  • OS: Docker

Additional context
pulsar tag v2.5.0
@frejonb frejonb added the type/bug The PR fixed a bug or issue reported a bug label Jan 18, 2020
@sijie sijie mentioned this issue Jan 18, 2020
Closed
@sijie
Copy link
Member

sijie commented Jan 20, 2020

@frejonb I don't think python function supports this feature yet.

@Anonymitaet we need to improve the documentation about this part.

@sijie sijie added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Jan 20, 2020
@sijie sijie added this to the 2.5.1 milestone Jan 20, 2020
@sijie sijie mentioned this issue Jan 20, 2020
Merged
@sijie
Copy link
Member

sijie commented Jan 20, 2020

The dead letter topic support in java functions also has one problem. #6101 is used for addressing the problem in java functions.

Python functions doesn't support this feature at all.

codelipenghui pushed a commit that referenced this issue Jan 21, 2020
@sijie @codelipenghui
[Functions] The argument and description for dead letter topic is wro…
c6e258d 
…ng (#6101)

*Motivation*

Related to #6084

 #5400 introduces `customRuntimeOptions` in function details. But the description was wrong. The mistake was probably introduced by bad merges.

*Modification*

Fix the argument and description for `deadletterTopic` and `customRuntimeOptions`.
@sijie sijie modified the milestones: 2.5.1, 2.6.0 Jan 22, 2020
tuteng pushed a commit to AmateurEvents/pulsar that referenced this issue Feb 23, 2020
@sijie @tuteng
[Functions] The argument and description for dead letter topic is wro…
b70b15c 
…ng (apache#6101)

*Motivation*

Related to apache#6084

 apache#5400 introduces `customRuntimeOptions` in function details. But the description was wrong. The mistake was probably introduced by bad merges.

*Modification*

Fix the argument and description for `deadletterTopic` and `customRuntimeOptions`.
tuteng pushed a commit to AmateurEvents/pulsar that referenced this issue Mar 21, 2020
@sijie @tuteng
[Functions] The argument and description for dead letter topic is wro…
e32173e 
…ng (apache#6101)

*Motivation*

Related to apache#6084

 apache#5400 introduces `customRuntimeOptions` in function details. But the description was wrong. The mistake was probably introduced by bad merges.

*Modification*

Fix the argument and description for `deadletterTopic` and `customRuntimeOptions`.

(cherry picked from commit c6e258d)
tuteng pushed a commit that referenced this issue Apr 13, 2020
@sijie @tuteng
[Functions] The argument and description for dead letter topic is wro…
acdd987 
…ng (#6101)

*Motivation*

Related to #6084

 #5400 introduces `customRuntimeOptions` in function details. But the description was wrong. The mistake was probably introduced by bad merges.

*Modification*

Fix the argument and description for `deadletterTopic` and `customRuntimeOptions`.

(cherry picked from commit c6e258d)
jiazhai pushed a commit to jiazhai/pulsar that referenced this issue May 18, 2020
@sijie @jiazhai
[Functions] The argument and description for dead letter topic is wro…
d4eaf0f 
…ng (apache#6101)

*Motivation*

Related to apache#6084

 apache#5400 introduces `customRuntimeOptions` in function details. But the description was wrong. The mistake was probably introduced by bad merges.

*Modification*

Fix the argument and description for `deadletterTopic` and `customRuntimeOptions`.
(cherry picked from commit c6e258d)
@Huanli-Meng Huanli-Meng mentioned this issue May 19, 2020
Merged
1 task
@codelipenghui
Copy link
Contributor

@sijie Looks we can move this issue to 2.7.0 and we can add a help-wanted tag. If anyone contributes this feature before 2.6.0 release, we can move it back.

@codelipenghui codelipenghui modified the milestones: 2.6.0, 2.7.0 May 19, 2020
@Huanli-Meng
Copy link
Contributor

The doc is updated and merged, here is the PR link: #6980

@sijie sijie closed this as completed Jun 10, 2020
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this issue Aug 24, 2020
@sijie @huangdx0726
[Functions] The argument and description for dead letter topic is wro…
a3edcbe 
…ng (apache#6101)

*Motivation*

Related to apache#6084

 apache#5400 introduces `customRuntimeOptions` in function details. But the description was wrong. The mistake was probably introduced by bad merges.

*Modification*

Fix the argument and description for `deadletterTopic` and `customRuntimeOptions`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. help wanted type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
2.7.0
Development

No branches or pull requests
5 participants
@sijie @codelipenghui @frejonb @Huanli-Meng @Anonymitaet