Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeyValue schema doesn't handle null key and null value well #4804

Closed
sijie opened this issue Jul 25, 2019 · 1 comment · Fixed by #7139
Closed

KeyValue schema doesn't handle null key and null value well #4804

sijie opened this issue Jul 25, 2019 · 1 comment · Fixed by #7139
Labels
area/client type/bug The PR fixed a bug or issue reported a bug
Milestone
2.6.0

Comments

@sijie
Copy link
Member

sijie commented Jul 25, 2019

Describe the bug

Similar as #4803, it is impossible to specify null key or null value in KeyValue schema. It throws exception as below:

java.lang.NullPointerException
	at java.util.Base64$Encoder.encode(Base64.java:261)
	at java.util.Base64$Encoder.encodeToString(Base64.java:315)
	at org.apache.pulsar.client.impl.TypedMessageBuilderImpl.value(TypedMessageBuilderImpl.java:109)

To Reproduce

producer.newMessage().value(new KeyValue(null, "test-value")).send();

Expected behavior

Be able to support null key and null value.
@sijie sijie added type/bug The PR fixed a bug or issue reported a bug area/client component/schemaregistry labels Jul 25, 2019
@sijie sijie added this to the 2.4.1 milestone Jul 25, 2019
@jiazhai
Copy link
Member

jiazhai commented Aug 20, 2019

@sijie How about move this into 2.5.0?

@jiazhai jiazhai modified the milestones: 2.4.1, 2.5.0 Aug 22, 2019
@sijie sijie modified the milestones: 2.5.0, 2.6.0 Nov 25, 2019
@sijie sijie mentioned this issue Dec 27, 2019
Closed
@nlu90 nlu90 mentioned this issue Feb 20, 2020
Closed
1 task
@gaoran10 gaoran10 mentioned this issue Jun 2, 2020
Merged
1 task
codelipenghui pushed a commit that referenced this issue Jun 4, 2020
@gaoran10
Support KeyValue Schema Use Null Key And Null Value (#7139)
1d5ff26 
Fixes #4804  

Thanks, @nlu90, work at #6384.

### Motivation

Currently, the KeyValue schema doesn't handle `null` key and `null` value well.
cdbartholomew pushed a commit to kafkaesque-io/pulsar that referenced this issue Jul 24, 2020
@gaoran10 @cdbartholomew
Support KeyValue Schema Use Null Key And Null Value (apache#7139)
6bc8af2 
Fixes apache#4804  

Thanks, @nlu90, work at apache#6384.

### Motivation

Currently, the KeyValue schema doesn't handle `null` key and `null` value well.
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this issue Aug 24, 2020
@gaoran10 @huangdx0726
Support KeyValue Schema Use Null Key And Null Value (apache#7139)
6d08a44 
Fixes apache#4804  

Thanks, @nlu90, work at apache#6384.

### Motivation

Currently, the KeyValue schema doesn't handle `null` key and `null` value well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/client type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
2.6.0
2 participants
@sijie @jiazhai