-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[improve] [pip] PIP-357: Correct the conf name in load balance module. (
- Loading branch information
1 parent
fb03d15
commit fb80007
Showing
1 changed file
with
35 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
# PIP-357: Correct the conf name in load balance module. | ||
|
||
# Background knowledge | ||
|
||
We use `loadBalancerBandwithInResourceWeight` and `loadBalancerBandwithOutResourceWeight` to calculate the broker's load in the load balance module. However, the correct conf name should be `loadBalancerBandwidthInResourceWeight` and `loadBalancerBandwidthOutResourceWeight`. This PIP is to correct the conf name in the load balance module. | ||
|
||
# Motivation | ||
|
||
The current conf name is incorrect. | ||
|
||
|
||
# Detailed Design | ||
|
||
- deprecated `loadBalancerBandwithInResourceWeight` and `loadBalancerBandwithOutResourceWeight` in the load balance module. | ||
- add `loadBalancerBandwidthInResourceWeight` and `loadBalancerBandwidthOutResourceWeight` in the load balance module. | ||
|
||
In case of users upgrading to this version don't notice the change, we will still support the old conf name in following way: | ||
- If a configuration is not the default configuration, use that configuration. | ||
- If both the new and the old are configured different from the default value, use the new one. | ||
|
||
# Backward & Forward Compatibility | ||
|
||
Backward compatible, users can upgrade to this version without doing any changes and the old conf name will still work. | ||
If user want to use the new conf name, they can change the conf name in the configuration file. | ||
Just remember that if both the new and the old are configured different from the default value, the new one will be used. | ||
|
||
# General Notes | ||
|
||
# Links | ||
|
||
<!-- | ||
Updated afterwards | ||
--> | ||
* Mailing List discussion thread: https://lists.apache.org/thread/31wfq2hhprn4zknp4jv21lzf5809q6lf | ||
* Mailing List voting thread: https://lists.apache.org/thread/0pggcploqw43mo134cwmk7b3p7t13848 |