[improve][broker] Remove unused method CompactionRecord.reset (#22670)

apache · May 8, 2024 · ad75e3f · ad75e3f
1 parent ada31a9
commit ad75e3f
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 17 deletions.
diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/compaction/CompactionRecord.java b/pulsar-broker/src/main/java/org/apache/pulsar/compaction/CompactionRecord.java
@@ -51,14 +51,6 @@ public class CompactionRecord {
     public final Rate writeRate = new Rate();
     public final Rate readRate = new Rate();
 
-    public void reset() {
-        compactionRemovedEventCount.reset();
-        compactionSucceedCount.reset();
-        compactionFailedCount.reset();
-        compactionDurationTimeInMills.reset();
-        writeLatencyStats.reset();
-    }
-
     public void addCompactionRemovedEvent() {
         lastCompactionRemovedEventCountOp.increment();
         compactionRemovedEventCount.increment();

diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/compaction/CompactorMXBeanImpl.java b/pulsar-broker/src/main/java/org/apache/pulsar/compaction/CompactorMXBeanImpl.java
@@ -53,10 +53,6 @@ public Set<String> getTopics() {
         return compactionRecordOps.keySet();
     }
 
-    public void reset() {
-        compactionRecordOps.values().forEach(CompactionRecord::reset);
-    }
-
     public void addCompactionReadOp(String topic, long readableBytes) {
         compactionRecordOps.computeIfAbsent(topic, k -> new CompactionRecord()).addCompactionReadOp(readableBytes);
     }

diff --git a/pulsar-broker/src/test/java/org/apache/pulsar/compaction/CompactorMXBeanImplTest.java b/pulsar-broker/src/test/java/org/apache/pulsar/compaction/CompactorMXBeanImplTest.java
@@ -59,11 +59,6 @@ public void testSimple() throws Exception {
         assertTrue(compaction.getCompactionWriteThroughput() > 0L);
         mxBean.addCompactionLatencyOp(topic, 10, TimeUnit.NANOSECONDS);
         assertTrue(compaction.getCompactionLatencyBuckets()[0] > 0L);
-        mxBean.reset();
-        assertEquals(compaction.getCompactionRemovedEventCount(), 0, 0);
-        assertEquals(compaction.getCompactionSucceedCount(), 0, 0);
-        assertEquals(compaction.getCompactionFailedCount(), 0, 0);
-        assertEquals(compaction.getCompactionDurationTimeInMills(), 0, 0);
     }
 
 }