update

apache · Jul 6, 2021 · 5edbfef · 5edbfef
1 parent 3c45126
commit 5edbfef
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/...broker/src/test/java/org/apache/pulsar/client/impl/PatternTopicsConsumerImplAuthTest.java b/...broker/src/test/java/org/apache/pulsar/client/impl/PatternTopicsConsumerImplAuthTest.java
@@ -76,6 +76,7 @@ public class PatternTopicsConsumerImplAuthTest extends ProducerConsumerBase {
     private static final long testTimeout = 90000; // 1.5 min
     private static final Logger log = LoggerFactory.getLogger(PatternTopicsConsumerImplAuthTest.class);
     private static final String clientRole = "pluggableRole";
+    private static final String superUserRole = "superUser";
     private static final Set<String> clientAuthProviderSupportedRoles = Sets.newHashSet(clientRole);
 
     @Override
@@ -88,7 +89,7 @@ public void setup() throws Exception {
         conf.setAuthorizationEnabled(true);
 
         Set<String> superUserRoles = new HashSet<>();
-        superUserRoles.add("superUser");
+        superUserRoles.add(superUserRole);
         conf.setSuperUserRoles(superUserRoles);
 
         Set<String> providers = new HashSet<>();
@@ -109,7 +110,7 @@ protected void cleanup() throws Exception {
     }
 
     private PulsarAdmin buildAdminClient() throws Exception {
-        Authentication adminAuthentication = new ClientAuthentication("superUser");
+        Authentication adminAuthentication = new ClientAuthentication(superUserRole);
         return PulsarAdmin.builder()
                 .serviceHttpUrl(brokerUrl.toString())
                 .authentication(adminAuthentication)
@@ -341,7 +342,7 @@ public CompletableFuture<Boolean> allowNamespaceOperationAsync(
                 NamespaceName namespaceName, String role, NamespaceOperation operation, AuthenticationDataSource authData) {
             CompletableFuture<Boolean> isAuthorizedFuture;
 
-            if (role.equals("superUser") || role.equals(clientRole)) {
+            if (role.equals(superUserRole) || role.equals(clientRole)) {
                 isAuthorizedFuture = CompletableFuture.completedFuture(true);
             } else {
                 isAuthorizedFuture = CompletableFuture.completedFuture(false);
@@ -365,7 +366,7 @@ public CompletableFuture<Boolean> allowTopicOperationAsync(
                 TopicName topic, String role, TopicOperation operation, AuthenticationDataSource authData) {
             CompletableFuture<Boolean> isAuthorizedFuture;
 
-            if (role.equals("superUser") || role.equals(clientRole)) {
+            if (role.equals(superUserRole) || role.equals(clientRole)) {
                 isAuthorizedFuture = CompletableFuture.completedFuture(true);
             } else {
                 isAuthorizedFuture = CompletableFuture.completedFuture(false);
@@ -390,7 +391,7 @@ public CompletableFuture<Boolean> allowTopicPolicyOperationAsync(TopicName topic
                                                                          AuthenticationDataSource authData) {
             CompletableFuture<Boolean> isAuthorizedFuture;
 
-            if (role.equals("superUser") || role.equals(clientRole)) {
+            if (role.equals(superUserRole) || role.equals(clientRole)) {
                 isAuthorizedFuture = CompletableFuture.completedFuture(true);
             } else {
                 isAuthorizedFuture = CompletableFuture.completedFuture(false);