add root path '/' for valid path

apache · Nov 9, 2021 · 0528c16 · 0528c16
1 parent 38f623b
commit 0528c16
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/AbstractMetadataStore.java b/pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/AbstractMetadataStore.java
@@ -320,10 +320,11 @@ protected static String parent(String path) {
      * valid path in metadata store should be
      * 1. not blank
      * 2. starts with '/'
-     * 3. not ends with '/', (excludes single "/")
+     * 3. not ends with '/', except root path "/"
      */
     public static boolean isValidPath(String path) {
-        return StringUtils.isNotBlank(path)
+        return StringUtils.equals(path, "/")
+                || StringUtils.isNotBlank(path)
                 && path.startsWith("/")
                 && !path.endsWith("/");
     }

diff --git a/pulsar-metadata/src/test/java/org/apache/pulsar/metadata/LocalMemoryMetadataStoreTest.java b/pulsar-metadata/src/test/java/org/apache/pulsar/metadata/LocalMemoryMetadataStoreTest.java
@@ -81,7 +81,7 @@ public void testPathValid() {
         assertFalse(AbstractMetadataStore.isValidPath(null));
         assertFalse(AbstractMetadataStore.isValidPath(""));
         assertFalse(AbstractMetadataStore.isValidPath(" "));
-        assertFalse(AbstractMetadataStore.isValidPath("/"));
+        assertTrue(AbstractMetadataStore.isValidPath("/"));
         assertTrue(AbstractMetadataStore.isValidPath("/test"));
         assertFalse(AbstractMetadataStore.isValidPath("/test/"));
         assertTrue(AbstractMetadataStore.isValidPath("/test/ABC"));