[feat] Add producer interceptor#169
Conversation
a430d2f to
abc6a7f
Compare
BewareMyPower
left a comment
There was a problem hiding this comment.
All the tests should check what latch.wait returns and the side effects made by the different interceptors.
* Use param test for InterceptorsTest * Check latch * Add tests for partitioned topic * Improve dependency of Producer.h * Improve interceptors insertion in ProducerConfiguration * Add close interceptors calls
|
Could you solve the conflicts? |
Done. PTAL again. Thanks. |
BewareMyPower
left a comment
There was a problem hiding this comment.
I've left two comments about the coding style. These should not be blockers so I dismissed my requested changes before.
|
@RobertIndie The main branch is broken due to a recent upgrade of |
|
Hi @RobertIndie, thanks for introducing this great feature! As we discussed just now, for the doc side: ✅ Pulsar feature matrixI've ticked the boxes of "Interceptors" for C++ producer and consumer. ✅ Pulsar client docsCould you please provide the following tech inputs? TIA! The following docs are only added to |


Master Issue: #150
Motivation
This is the producer interceptor implementation of #150.
Modifications
interceptandgetInterceptorsinProducerConfiguration.beforeSend,onSendAcknowledgement,onPartitionsChangeandclose.Verifying this change
This change added tests.
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)