Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #45] [pulsar-client-kafka-compat] Handled Kafka record headers… #46

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

swamymavuri
Copy link

@swamymavuri swamymavuri commented Mar 15, 2023

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #45

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Kafka Record Headers are not being handled with compat library

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.
Retreived header variables from the record headers and update it to messagebuilder in producer.
Retreived messsage properties and update it to consumer record

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:
Added PulsarKafkaConsumerTest to cover PulsarKafkaConsumer code flow
(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@swamymavuri swamymavuri changed the title Fix [Issue #45] [pulsar-client-kafka-compat] Handled Kafka record headers… [Issue #45] [pulsar-client-kafka-compat] Handled Kafka record headers… Mar 15, 2023
@@ -37,6 +37,7 @@
import java.util.concurrent.TimeoutException;
import java.util.stream.Collectors;

import org.apache.commons.codec.binary.Hex;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this import used at all?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, while encoding the kafka record headers

@lhotari lhotari requested review from cbornet and dlg99 March 23, 2023 05:45
@swamymavuri swamymavuri requested review from lhotari and removed request for dlg99 and cbornet March 23, 2023 13:21
}

@Test
public void testPulsarKafkaConsumer() throws Exception {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what this test does. There are no assertions, no messages, no headers verification, ...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added assertion statements for Header Verification

@swamymavuri swamymavuri requested review from cbornet and removed request for lhotari March 26, 2023 13:34
@swamymavuri swamymavuri requested a review from cbornet April 1, 2023 11:04
@swamymavuri
Copy link
Author

@cbornet , Can you please take a look at this PR and let me know if i need to add any

@lhotari
Copy link
Member

lhotari commented Nov 27, 2023

It would be useful to have an integration test. There are existing integrations tests in https://github.com/apache/pulsar-adapters/blob/master/tests/pulsar-kafka-compat-client-test/src/test/java/org/apache/pulsar/tests/integration/compat/kafka/ . Please add one for validation the correct behavior. You could add test methods to the existing KafkaApiTest, for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kafka record headers are not being handled
4 participants