-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue #45] [pulsar-client-kafka-compat] Handled Kafka record headers… #46
base: master
Are you sure you want to change the base?
Conversation
…eaders for producer and consumer
...ar-client-kafka/src/test/java/org/apache/kafka/clients/producer/PulsarKafkaProducerTest.java
Outdated
Show resolved
Hide resolved
@@ -37,6 +37,7 @@ | |||
import java.util.concurrent.TimeoutException; | |||
import java.util.stream.Collectors; | |||
|
|||
import org.apache.commons.codec.binary.Hex; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this import used at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, while encoding the kafka record headers
...pulsar-client-kafka/src/main/java/org/apache/kafka/clients/consumer/PulsarKafkaConsumer.java
Outdated
Show resolved
Hide resolved
...ar-client-kafka/src/test/java/org/apache/kafka/clients/consumer/PulsarKafkaConsumerTest.java
Outdated
Show resolved
Hide resolved
} | ||
|
||
@Test | ||
public void testPulsarKafkaConsumer() throws Exception { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand what this test does. There are no assertions, no messages, no headers verification, ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added assertion statements for Header Verification
...ar-client-kafka/src/test/java/org/apache/kafka/clients/producer/PulsarKafkaProducerTest.java
Outdated
Show resolved
Hide resolved
...ar-client-kafka/src/test/java/org/apache/kafka/clients/consumer/PulsarKafkaConsumerTest.java
Outdated
Show resolved
Hide resolved
@cbornet , Can you please take a look at this PR and let me know if i need to add any |
...ar-client-kafka/src/test/java/org/apache/kafka/clients/consumer/PulsarKafkaConsumerTest.java
Outdated
Show resolved
Hide resolved
It would be useful to have an integration test. There are existing integrations tests in https://github.com/apache/pulsar-adapters/blob/master/tests/pulsar-kafka-compat-client-test/src/test/java/org/apache/pulsar/tests/integration/compat/kafka/ . Please add one for validation the correct behavior. You could add test methods to the existing KafkaApiTest, for example. |
(If this PR fixes a github issue, please add
Fixes #<xyz>
.)Fixes #45
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>
to link to the master issue.)Master Issue: #
Motivation
Kafka Record Headers are not being handled with compat library
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
Describe the modifications you've done.
Retreived header variables from the record headers and update it to messagebuilder in producer.
Retreived messsage properties and update it to consumer record
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
Added PulsarKafkaConsumerTest to cover PulsarKafkaConsumer code flow
(example:)
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation