Skip to content

Set the correct HTTP Header, Accept not Accepts #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
collado-mike merged 1 commit into from
Aug 5, 2024
Merged

Set the correct HTTP Header, Accept not Accepts #93

collado-mike merged 1 commit into from
Aug 5, 2024

Conversation

@kevinjqliu
Copy link
Contributor

@kevinjqliu kevinjqliu commented Aug 5, 2024 •
edited
Loading

Description

Scripts in regtests running curl command specifies header as Accepts, whereas the proper header should be Accept
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Accept

I don’t believe this will have any functional impact.

Fixes #92

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Ran regtests, docker compose up --build --exit-code-from regtest

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

Please delete options that are not relevant.

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • If adding new functionality, I have discussed my implementation with the community using the linked GitHub issue
  • I have signed and submitted the ICLA and if needed, the CCLA. See Contributing for details.

@kevinjqliu kevinjqliu marked this pull request as ready for review August 5, 2024 17:18
@kevinjqliu kevinjqliu requested a review from a team as a code owner August 5, 2024 17:18
collado-mike
collado-mike approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@collado-mike collado-mike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@collado-mike collado-mike merged commit 36d3234 into apache:main Aug 5, 2024
@kevinjqliu kevinjqliu deleted the kevinjqliu/accept-not-accepts branch August 5, 2024 19:01
snazy pushed a commit to snazy/polaris that referenced this pull request Nov 20, 2025
@dimas-b
feat: Support customizing S3 endpoints (apache#1913) (apache#93)
8e99fe0 
No functional change.

Introduce a dedicated interface for `StsClient` suppliers and implement it using a pool of cached clients.

All client are "thin" and share the same `SdkHttpClient`. The latter is closed when the server shuts down.

This is a step towards supporting non-AWS S3 storage (apache#1530).
For this reason the STS endpoint is present in new interfaces, but is not used yet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adutra adutra adutra approved these changes

@collado-mike collado-mike collado-mike approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] regtests set the wrong HTTP header, Accept not `Accepts

3 participants

@kevinjqliu @adutra @collado-mike