docs: adapt metastores.md to Quarkus #831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adutra
requested review from
RussellSpitzer,
ashvina,
collado-mike,
dennishuo,
dimas-b,
ebyhr,
eric-maynard,
flyrain,
jackye1995,
jbonofre,
snazy,
takidau and
vvcephei
as code owners
adutra
force-pushed
the
metastore-docs
branch
2 times, most recently
from
a09a937 to
e256ace
Compare
adutra
force-pushed
the
metastore-docs
branch
from
e256ace to
4b1fa04
Compare
adutra
added
the
documentation
dimas-b
approved these changes
Jan 22, 2025
Contributor
|
cc @aihuaxu |
flyrain
approved these changes
Jan 23, 2025
Contributor
flyrain
left a comment
flyrain
left a comment
There was a problem hiding this comment.
LGTM with minor comments.
|
|
||
| > Note: some database systems such as Postgres don't create databases automatically. Database admins need to create them manually before running Polaris server. | ||
| A single `persistence.xml` can describe multiple [persistence units](https://eclipse.dev/eclipselink/documentation/2.6/concepts/app_dev001.htm). For example, with both a `polaris-dev` and `polaris` persistence unit defined, you could use a single `persistence.xml` to easily switch between development and production databases. Use the `persistence-unit` option in the Polaris server configuration to easily switch between persistence units. |
Contributor
There was a problem hiding this comment.
It'd be nice to give an example of a single file with multiple units. But it isn't a blocker to me. We can improve on it later.
flyrain
approved these changes
Jan 23, 2025
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this PR assumes #610 will get merged in its current state.