Fix catalog names in integration tests #769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adutra
requested review from
RussellSpitzer,
ashvina,
collado-mike,
dimas-b,
ebyhr,
eric-maynard,
flyrain,
jackye1995,
jbonofre,
snazy,
takidau and
vvcephei
as code owners
A few tests were still creating catalog names "manually". Depending on the order of test execution, you could see test failures, e.g. in `ManagementServiceIntegrationTest#testListCatalogs()`: ``` expected: [] but was: [...] ``` Because some catalogs created in previous tests weren't deleted.
adutra
force-pushed
the
integration-tests-catalog-name-fixes
branch
from
645dbe7 to
10d89c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few tests were still creating catalog names "manually". Depending on the order of test execution, you could see test failures, e.g. in
ManagementServiceIntegrationTest#testListCatalogs():Because some catalogs created in previous tests weren't deleted.