Helm: add bootstrapExtraEnv for bootstrapping job
#601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gerrit-K
requested review from
RussellSpitzer,
adutra,
ashvina,
collado-mike,
ebyhr,
eric-maynard,
flyrain,
jackye1995,
jbonofre,
snazy,
takidau and
vvcephei
as code owners
adutra
reviewed
Jan 2, 2025
Gerrit-K
force-pushed
the
helm-extraenv-to-job
branch
from
163884e to
51ab321
Compare
Gerrit-K
changed the title
extraEnv to bootstrapping jobbootstrapExtraEnv for bootstrapping job
adutra
approved these changes
Jan 2, 2025
Gerrit-K
force-pushed
the
helm-extraenv-to-job
branch
from
51ab321 to
6de9eea
Compare
dimas-b
approved these changes
Jan 2, 2025
adutra
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This passes down the
extraEnvvalues to the bootstrapping job as well. This is needed in order to set initial bootstrapping credentials viaPOLARIS_BOOTSTRAP_DEFAULT-REALM_ROOT_CLIENT_IDandPOLARIS_BOOTSTRAP_DEFAULT-REALM_ROOT_CLIENT_SECRET. In contrast to the ad-hoc bootstrapping of the application (when in in-memory mode), the initial credentials are not printed to stdout, so they cannot be used if not explicitly set via these variables.