-
Notifications
You must be signed in to change notification settings - Fork 385
License report & automatic LICENSE content check
#54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9860a72
Add license report + `NOTICE` content check
snazy 997f5dd
Update LICENSE
snazy c4c4063
Must mention Apache licensed artifacts, address review comments
snazy ae4fd03
update LICENSE
snazy d28bb6b
fix license header
snazy 10e65d9
typos et al
snazy 6d709a8
another left-over licesne
snazy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| import org.gradle.kotlin.dsl.support.unzipTo | ||
|
|
||
| val licenseReports by configurations.creating { description = "Used to generate license reports" } | ||
|
|
||
| dependencies { | ||
| licenseReports(project(":polaris-service", "licenseReports")) | ||
| } | ||
|
|
||
| val collectLicenseReportJars by | ||
| tasks.registering(Sync::class) { | ||
| destinationDir = project.layout.buildDirectory.dir("tmp/license-report-jars").get().asFile | ||
| from(licenseReports) | ||
| } | ||
|
|
||
| val aggregateLicenseReports by | ||
| tasks.registering { | ||
| group = "Build" | ||
| description = "Aggregates license reports" | ||
| val outputDir = project.layout.buildDirectory.dir("licenseReports") | ||
| outputs.dir(outputDir) | ||
| dependsOn(collectLicenseReportJars) | ||
| doLast { | ||
| delete(outputDir) | ||
| fileTree(collectLicenseReportJars.get().destinationDir).files.forEach { zip -> | ||
| val targetDirName = zip.name.replace("-license-report.zip", "") | ||
| unzipTo(outputDir.get().dir(targetDirName).asFile, zip) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| val aggregatedLicenseReportsZip by | ||
| tasks.registering(Zip::class) { | ||
| from(aggregateLicenseReports) | ||
| from(rootProject.layout.projectDirectory) { | ||
| include("NOTICE", "LICENSE") | ||
| eachFile { | ||
| path = file.name + ".txt" | ||
| } | ||
| } | ||
| archiveBaseName.set("polaris-aggregated-license-report-${project.version}") | ||
| destinationDirectory.set(layout.buildDirectory.dir("distributions")) | ||
| archiveExtension.set("zip") | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,120 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| import com.github.jk1.license.LicenseReportExtension | ||
| import com.github.jk1.license.ProjectData | ||
| import com.github.jk1.license.filter.DependencyFilter | ||
| import java.io.File | ||
| import org.gradle.api.GradleException | ||
|
|
||
| /** | ||
| * Validates that all dependencies with MIT/BSD/Go/UPL/ISC licenses, and Apache | ||
| * license, are mentioned in the `LICENSE` file. | ||
| */ | ||
| class LicenseFileValidation : DependencyFilter { | ||
| val needsApacheLicenseMention = setOf("Apache") | ||
|
|
||
| val needsFullLicenseMention = setOf("MIT", "BSD", "Go", "ISC", "Universal Permissive") | ||
|
|
||
| fun doesNeedApacheMention(licenses: List<String?>): Boolean { | ||
| for (license in licenses) { | ||
| if (license != null) { | ||
| if (needsApacheLicenseMention.any { license.contains(it) }) { | ||
| return true | ||
| } | ||
| } | ||
| } | ||
| return false | ||
| } | ||
|
|
||
| fun doesNeedFullMention(licenses: List<String?>): Boolean { | ||
| for (license in licenses) { | ||
| if (license != null) { | ||
| if (needsFullLicenseMention.any { license.contains(it) }) { | ||
| return true | ||
| } | ||
| } | ||
| } | ||
| // no licenses ! | ||
| return true | ||
| } | ||
|
|
||
| override fun filter(data: ProjectData?): ProjectData { | ||
| data!! | ||
|
|
||
| val rootLicenseFile = data.project.rootProject.file("LICENSE").readText() | ||
|
|
||
| val licenseReport = data.project.extensions.getByType(LicenseReportExtension::class.java) | ||
|
|
||
| val missingApacheMentions = mutableSetOf<String>() | ||
| val missingFullMentions = mutableMapOf<String, String>() | ||
|
|
||
| data.allDependencies.forEach { mod -> | ||
| val licenses = | ||
| (mod.manifests.map { it.license } + | ||
| mod.licenseFiles.flatMap { it.fileDetails }.map { it.license } + | ||
| mod.poms.flatMap { it.licenses }.map { it.name }) | ||
| .distinct() | ||
|
|
||
| val groupModule = "${mod.group}:${mod.name}" | ||
| val groupModuleRegex = "^$groupModule$".toRegex(RegexOption.MULTILINE) | ||
| if (!groupModuleRegex.containsMatchIn(rootLicenseFile)) { | ||
| if (doesNeedApacheMention(licenses)) { | ||
| missingApacheMentions.add(groupModule) | ||
| } else if (doesNeedFullMention(licenses)) { | ||
| missingFullMentions[groupModule] = """ | ||
| --- | ||
| $groupModule | ||
|
|
||
| ${mod.licenseFiles.flatMap { it.fileDetails }.filter { it.file != null }.map { it.file } | ||
| .map { File("${licenseReport.absoluteOutputDir}/$it").readText().trim() } | ||
| .distinct() | ||
| .map { "\n\n$it\n" } | ||
| .joinToString("\n") | ||
| } | ||
| """.trimIndent() | ||
| } | ||
| } | ||
| } | ||
|
|
||
| val missingError = StringBuilder() | ||
| if (!missingApacheMentions.isEmpty()) { | ||
| missingError.append("\n\nMissing Apache License mentions:") | ||
| missingError.append("\n--------------------------------\n") | ||
| missingApacheMentions.sorted().forEach { | ||
| missingError.append("\n$it") | ||
| } | ||
| } | ||
| if (!missingFullMentions.isEmpty()) { | ||
| missingError.append("\n\nMissing full license mentions:") | ||
| missingError.append("\n------------------------------\n") | ||
| missingFullMentions.toSortedMap().values.forEach { | ||
| missingError.append("\n$it") | ||
| } | ||
| } | ||
| if (!missingApacheMentions.isEmpty() || !missingFullMentions.isEmpty()) { | ||
|
|
||
| throw GradleException( | ||
| "License information for the following artifacts is missing in the root LICENSE file: $missingError" | ||
| ) | ||
| } | ||
|
|
||
| return data | ||
| } | ||
| } |
84 changes: 84 additions & 0 deletions
84
build-logic/src/main/kotlin/polaris-license-report.gradle.kts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| import com.github.jk1.license.filter.LicenseBundleNormalizer | ||
| import com.github.jk1.license.render.InventoryHtmlReportRenderer | ||
| import com.github.jk1.license.render.JsonReportRenderer | ||
| import com.github.jk1.license.render.XmlReportRenderer | ||
| import java.util.* | ||
|
|
||
| plugins { id("com.github.jk1.dependency-license-report") } | ||
|
|
||
| afterEvaluate { | ||
| licenseReport { | ||
| filters = | ||
| arrayOf( | ||
| LicenseBundleNormalizer( | ||
| "${rootProject.projectDir}/gradle/license/normalizer-bundle.json", | ||
| false | ||
| ), | ||
| LicenseFileValidation() | ||
| ) | ||
| allowedLicensesFile = rootProject.projectDir.resolve("gradle/license/allowed-licenses.json") | ||
| renderers = | ||
| arrayOf(InventoryHtmlReportRenderer("index.html"), JsonReportRenderer(), XmlReportRenderer()) | ||
| excludeBoms = true | ||
| outputDir = "${project.layout.buildDirectory.get()}/reports/dependency-license" | ||
| } | ||
| } | ||
|
|
||
| val generateLicenseReport = | ||
| tasks.named("generateLicenseReport") { | ||
| inputs | ||
| .files( | ||
| rootProject.projectDir.resolve("gradle/license/normalizer-bundle.json"), | ||
| rootProject.projectDir.resolve("gradle/license/allowed-licenses.json") | ||
| ) | ||
| .withPathSensitivity(PathSensitivity.RELATIVE) | ||
| inputs.property("renderersHash", Arrays.hashCode(licenseReport.renderers)) | ||
| inputs.property("filtersHash", Arrays.hashCode(licenseReport.filters)) | ||
| inputs.property("excludesHash", Arrays.hashCode(licenseReport.excludes)) | ||
| inputs.property("excludeGroupsHash", Arrays.hashCode(licenseReport.excludeGroups)) | ||
| } | ||
|
|
||
| val licenseReportZip = | ||
| tasks.register<Zip>("licenseReportZip") { | ||
| group = "documentation" | ||
| description = "License report as a ZIP" | ||
| dependsOn("checkLicense") | ||
| from(generateLicenseReport) | ||
| archiveClassifier.set("license-report") | ||
| archiveExtension.set("zip") | ||
| } | ||
|
|
||
| val licenseReports by | ||
| configurations.creating { | ||
| isCanBeConsumed = true | ||
| isCanBeResolved = false | ||
| description = "License report files" | ||
| outgoing { artifact(licenseReportZip) } | ||
| } | ||
|
|
||
| plugins.withType<MavenPublishPlugin>().configureEach { | ||
| configure<PublishingExtension> { | ||
| publications { named<MavenPublication>("maven") { artifact(licenseReportZip) } } | ||
| } | ||
| } | ||
|
|
||
| tasks.named("check") { dependsOn(generateLicenseReport) } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't we just automatically check whether or not our license file matches our dependencies ? We could always do this in a future PR