Remove dropwizard-jackson dep from core #470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimas-b
requested review from
RussellSpitzer,
adutra,
ashvina,
collado-mike,
ebyhr,
eric-maynard,
flyrain,
jackye1995,
jbonofre,
snazy,
takidau and
vvcephei
as code owners
dimas-b
force-pushed
the
remove-dw-from-core2
branch
from
2ccfe20 to
e70180f
Compare
Contributor
Author
|
This is an alternative to #435 |
snazy
approved these changes
Nov 25, 2024
adutra
approved these changes
Nov 25, 2024
eric-maynard
approved these changes
Nov 25, 2024
Contributor
eric-maynard
left a comment
eric-maynard
left a comment
There was a problem hiding this comment.
This may be better than the approach in #435, thanks for iterating on this. LGTM
Contributor
Author
|
@collado-mike : What's your take on this alternative approach? |
jbonofre
approved these changes
Nov 26, 2024
This is a simplification / cleanup. The dependency does not appear to be required in `polaris-core` Add custom code to `PolarisApplication` find classes directly listed in the `Discoverable` service descriptor and register them with the ObjectMapper. This approach to finding sub-types is consistent both with the java service descriptors (listed types actually implement the service interface) and at the same time allows moving the Dropwizard `Discoverable` dependencies to the polaris-service module that actually integrates with Dropwizard. Move leaf metastore classes to the `Discoverable` service descriptor in their respective module. Note: this fixes the cross-jar leak of EclipseLinkPolarisMetaStoreManagerFactory in service descriptors.
dimas-b
force-pushed
the
remove-dw-from-core2
branch
from
39c3f05 to
a29a910
Compare
Contributor
Author
|
rebased and resolved conflicts |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simplification / cleanup. The dependency does not appear to be required in
polaris-coreAdd custom code to
PolarisApplicationfind classes directly listed in theDiscoverableservice descriptor and register them with the ObjectMapper. This approach to finding sub-types is consistent both with the java service descriptors (listed types actually implement the service interface) and at the same time allows moving the DropwizardDiscoverabledependencies to the polaris-service module that actually integrates with Dropwizard.Move leaf metastore classes to the
Discoverableservice descriptor in their respective module.Note: this fixes the cross-jar leak of EclipseLinkPolarisMetaStoreManagerFactory in service descriptors.