Skip to content

Add PolarisEventType int codes and remove unused before/after commit view/table values.#3608

Merged
dimas-b merged 4 commits intoapache:mainfrom
evindj:remove_before_after_commit_event
Feb 3, 2026
Merged

Add PolarisEventType int codes and remove unused before/after commit view/table values.#3608
dimas-b merged 4 commits intoapache:mainfrom
evindj:remove_before_after_commit_event

Conversation

@evindj
Copy link
Contributor

@evindj evindj commented Jan 28, 2026 •
edited
Loading

This PR is a continuation of #3418 where we agreed we should remove associate enums values from Enum definition.
The code also adds a constructor to help not having to rely on ordinals() to to have enum codes.

I incremented enum code assignments by 100 based on categories. I am happy to take feedback here.

Does not change logic and removes only enums that are no longer used so behavior does not change.

./gradlew clean assemble -x test

Is successful.

Checklist

  • 🛡️ Don't disclose security issues! (contact security@apache.org)
  • 🔗 Clearly explained why the changes are needed, or linked related issues: Fixes #
  • 🧪 Added/updated tests with good coverage, or manually tested (and explained how)
  • 💡 Added comments for complex logic
  • 🧾 Updated CHANGELOG.md (if needed)
  • 📚 Updated documentation in site/content/in-dev/unreleased (if needed)

@github-project-automation github-project-automation bot moved this to PRs In Progress in Basic Kanban Board Jan 28, 2026
@evindj
Copy link
Contributor Author

evindj commented Jan 28, 2026

@adutra @snazy @dimas-b tagging you all for review. Since this is kind of breaking change since the ordinals will change, someone mentioned on a different thread that we should send a notice does anyone knows the process around that?

@adnanhemani
Copy link
Contributor

adnanhemani commented Jan 29, 2026

Not sure we need something this involved. I'd prefer instead to change the current name to NO_LONGER_USED_xxx with a comment that states what that enum value used to be prior.

snazy
snazy reviewed Jan 29, 2026
View reviewed changes
Copy link
Member

@snazy snazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach LGTM.

Having that code should satisfy potential needs for an integer value. It is a much safer way than relying on Enum.ordinal() or index in the Enum.values() array. Relying on ordinal stability has caused a lot of issues in the past in many code bases and is considered bad practice: ErrorProne has a good explanation of the problem.

Also +1 on removing the unused enum values.

Once there's a test case ensuring that no code is duplicated, this change is ready-to-merge IMO.

@github-project-automation github-project-automation bot moved this from PRs In Progress to Ready to merge in Basic Kanban Board Jan 29, 2026
dimas-b
dimas-b reviewed Jan 29, 2026
View reviewed changes
Copy link
Contributor

@dimas-b dimas-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Introducing an explicit integer code as an alternative to enum ordinals SGTM 👍 I second points posted by @snazy .

I'd prefer to do old enum value removal and the introduction of the integer code in separate PRs, though... just for the sake of clarity.

@snazy snazy added this to the 1.4.0 milestone Jan 31, 2026
@snazy
Copy link
Member

snazy commented Feb 3, 2026

Ping @evindj . @dimas-b I think we can also just go ahead with this PR?

@evindj
Copy link
Contributor Author

evindj commented Feb 3, 2026

I don't see any risk associate with doing it in a single PR. I can see the angle of more clarity but quite frankly, splitting does not provide any addition safety guarantee beyond separating intent.

@dimas-b
Copy link
Contributor

dimas-b commented Feb 3, 2026

I'm ok with merging this PR, but it would be nice to update the title to mention adding integer enum codes... just for the sake of clarity. The title shows up in the "brief" git log after merging.

@dimas-b dimas-b changed the title remove before/after commit view/table enum values. Add PolarisEventType int codes and remove unused before/after commit view/table values. Feb 3, 2026
@dimas-b dimas-b merged commit 27824e8 into apache:main Feb 3, 2026
15 checks passed
@dimas-b
Copy link
Contributor

dimas-b commented Feb 3, 2026

Thanks for your contribution, @evindj !

@github-project-automation github-project-automation bot moved this from Ready to merge to Done in Basic Kanban Board Feb 3, 2026
@adutra adutra mentioned this pull request Feb 6, 2026
Closed
sungwy pushed a commit to sungwy/polaris that referenced this pull request Feb 7, 2026
@evindj @sungwy
Add PolarisEventType int codes and remove unused before/after commit …
38c6077 
…view/table values. (apache#3608)

This is a continuation of apache#3418 where we agreed we should remove associate enums values from Enum definition.

The code also adds a constructor to help not having to rely on ordinals() to to have enum codes.

I incremented enum code assignments by 100 based on categories. I am happy to take feedback here.

Does not change logic and removes only enums that are no longer used so behavior does not change.
snazy added a commit to snazy/polaris that referenced this pull request Feb 11, 2026
@snazy @evindj
@dimas-b @adutra @renovate-bot @nssalian @jbonofre @yushesp @carc-prathyush-shankar @RussellSpitzer
Dremio merge 2026 02 05 11 51 (apache#191)
bd34cc8 
* Releasey: adjust workflwo for Apache org level secrets (apache#3647)

See reference [INFRA-27430](https://issues.apache.org/jira/browse/INFRA-27430), requiring us to use `DOCKERHUB_USER` + `DOCKERHUB_TOKEN` instead of `DOCKERHUB_USERNAME` + `DOCKERHUB_TOKEN`.

* Guides: fix setup scripts to yield correct exit code (apache#3612)

The statements in the shell scripts for the setup services are often concatenated using `;`, which means that a previous' command exit code is _not_ propagated and the service, although it failed, is determined to be successful.

This change updates those scripts to use `&&` for the statement concatenation.

"Final" setup services (aka "polaris-setup") now have a final `sleep 120`. This is due to the behavior of `docker compose up --detach --wait`, which considers _any_ service (without dependants) that exits with exit code 0 as a failure, leading to that docker-compose command yielding an error code. That would break the guides testing code (apache#3553). That `sleep 120` in "polaris-setup" services does **not** cause a delay of the compose starting up - it is purely a "hack around" Docker Compose not having a notion of "setup services".

To avoid merge conflicts, this change also:
* updates affected `curl` invocations (as apache#3610)
* removes superfluous `restart: "no"`

* Add PolarisEventType int codes and remove unused before/after commit view/table values. (apache#3608)

This is a continuation of apache#3418 where we agreed we should remove associate enums values from Enum definition.

The code also adds a constructor to help not having to rely on ordinals() to to have enum codes.

I incremented enum code assignments by 100 based on categories. I am happy to take feedback here.

Does not change logic and removes only enums that are no longer used so behavior does not change.

* docs: Add quick guide for downstream builds (apache#3601)

* docs: Add quick guide for downstream builds

* IntegrationTestsHelper: fix extract & merge logic (apache#3650)

Both methods were flawed:

* `extractFromAnnotatedElements` wasn't properly delegating to the class if the method isn't annotated
* `mergeFromAnnotatedElements` wasn't properly prioritizing method properties over class properties.

* Community page: Yong Zheng - PPMC Member (apache#3653)

* chore(deps): update actions/checkout digest to de0fac2 (apache#3652)

* Use `quarkus.package.jar.type` (apache#3644)

Switch to `quarkus.package.jar.type` instead of the old `quarkus.package.type` build property as suggested by Quarkus build warning:

```
2026-02-03T00:26:05.672955189Z WorkerExecutor Queue WARN Configuration property 'quarkus.package.type' has been deprecated and replaced by: [quarkus.package.jar.enabled, quarkus.package.jar.type, quarkus.native.enabled, quarkus.native.sources-only]
```

* Site: Add blog post for Floe Polaris Integration (apache#3645)

* "Stale" job: restrict executions and adjust issue permissions (apache#3636)

* Add copyright on website (apache#3659)

* Sanitize principal names in AWS STS role session names (apache#3525)

Principal names containing invalid characters (spaces, parentheses,
etc.) were causing AWS STS AssumeRole requests to fail with validation
errors. AWS STS role session names must match the pattern [\w+=,.@-]*.

This change:
- Adds AwsRoleSessionNameSanitizer utility class to sanitize strings
  for use as AWS STS role session names
- Replaces invalid characters with underscores and truncates to 64
  characters (AWS maximum)
- Updates AwsCredentialsStorageIntegration to sanitize principal names
  when INCLUDE_PRINCIPAL_NAME_IN_SUBSCOPED_CREDENTIAL is enabled
- Adds tests to verify sanitization behavior and AWS pattern compliance

Fixes issue where principal names like "Joe (local)" would produce
invalid role session names like "polaris-Joe (local)" and cause
AssumeRole to fail. Now sanitized to "polaris-Joe__local_".

Co-authored-by: carc-prathyush-shankar <prathyush.shankar@carbonarc.co>

* Site: Adds the copyright message to all site pages (apache#3661)

* Site: Change Security link to local security reporting page (apache#3662)

* fix(deps): update dependency org.mongodb:mongodb-driver-sync to v5.6.3 (apache#3654)

* Releasey: use Apache org Nexus credentials (apache#3651)

* Releasey: use the correct SVN credentials (apache#3648)

* CI: Prerequisite PR for apache#3625 (apache#3646)

This change is only needed to update the required-checks to be able to eventually merge apache#3625.

* CI: all-in-one workflow (apache#3625)

This change moves all CI jobs into a single workflow. A single workflow comes with a couple advantages:
* all jobs are visible on one page
* option to re-run all failed jobs at once

The refactoring also simplifies the `.asf.yaml` file by referencing a single required check that can only succeeds if dependent jobs were successful.

The actual CI jobs are in the `ci.yml` file, which is only triggered via a `workflow_call` event.
There are two workflows that call `ci.yml`:
* `ci-main.yml` for `main` and `release/*` branches, with a concurrency group that does not cancel already running workflows
* `ci-pr.yml` for PRs with a concurrency group that cancels previous CI runs

The names of these two calling workflows include information that enrich the workflow view, and the workflows for main, release branches and PRs are grouped separartely in the GH Actions page for the repository. In other words, the reference name (for main + release branches) or the PR number and title are shown in the workflow runs list on the GH Actions page.

* Fix CI required checks (apache#3666)

* Add Sung as committer (apache#3665)

* Fix `CatalogFederationIntegrationTest.testFederatedCatalogWithCredentialVending()` for AWSSDK update (apache#3664)

Recent AWSSDK versions introduce `software.amazon.awssdk.services.s3.model.AccessDeniedException`, hence the assertion on `S3Exception` fails.

* CI/main: re-add commit message to `run_name` (apache#3668)

The default `run_name` value is, in case of `push` events, the commit message. This change re-adds the commit message.

* Add CI workflow to test against Iceberg unreleased versions (apache#3630)

* Update dependency software.amazon.awssdk:bom to v2.41.21 (apache#3639)

* Update actions/checkout digest to de0fac2 (apache#3671)

* Nit: Fix wrong `Nullable` import (apache#3672)

* Explicitly set build-time property `quarkus.datasource.db-kind` (apache#3674)

The property is set for the Polaris admin tool, but not for Polaris server. This causes a startup error with Quarkus 3.31.

Error message:
```
ERROR: Failed to start application
java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)
	at io.quarkus.runtime.Application.start(Application.java:116)
	at io.quarkus.runtime.ApplicationLifecycleManager.run(ApplicationLifecycleManager.java:119)
	at io.quarkus.runtime.Quarkus.run(Quarkus.java:79)
	at io.quarkus.runtime.Quarkus.run(Quarkus.java:50)
	at io.quarkus.runtime.Quarkus.run(Quarkus.java:143)
	at io.quarkus.runner.GeneratedMain.main(Unknown Source)
	at io.quarkus.bootstrap.runner.QuarkusEntryPoint.doRun(QuarkusEntryPoint.java:86)
	at io.quarkus.bootstrap.runner.QuarkusEntryPoint.main(QuarkusEntryPoint.java:37)
Caused by: java.lang.IllegalStateException: Build time property cannot be changed at runtime:
 - quarkus.datasource.db-kind is set to 'postgresql' but it is build time fixed to 'null'. Did you change the property quarkus.datasource.db-kind after building the application?
	at io.quarkus.runtime.configuration.ConfigRecorder.handleConfigChange(ConfigRecorder.java:72)
	at io.quarkus.runner.recorded.ConfigGenerationBuildStep$checkForBuildTimeConfigChange1532146938.deploy_6(Unknown Source)
	at io.quarkus.runner.recorded.ConfigGenerationBuildStep$checkForBuildTimeConfigChange1532146938.deploy(Unknown Source)
	... 9 more
```

* Last merged commit 2651e06

---------

Co-authored-by: Innocent Djiofack <djiofack007@gmail.com>
Co-authored-by: Dmitri Bourlatchkov <dmitri.bourlatchkov@gmail.com>
Co-authored-by: Alexandre Dutra <adutra@apache.org>
Co-authored-by: Mend Renovate <bot@renovateapp.com>
Co-authored-by: Neelesh Salian <nssalian@users.noreply.github.com>
Co-authored-by: JB Onofré <jbonofre@apache.org>
Co-authored-by: Prathyush Shankar <prathyush2018@gmail.com>
Co-authored-by: carc-prathyush-shankar <prathyush.shankar@carbonarc.co>
Co-authored-by: Russell Spitzer <russell.spitzer@GMAIL.COM>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snazy snazy snazy approved these changes

@dimas-b dimas-b dimas-b approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.4.0

Development

Successfully merging this pull request may close these issues.

4 participants

@evindj @adnanhemani @snazy @dimas-b