Skip to content

Use typed config for TABLE_METADATA_CLEANUP_BATCH_SIZE#3478

Merged
dimas-b merged 1 commit intoapache:mainfrom
dimas-b:metadata-batch-config
Jan 20, 2026
Merged

Use typed config for TABLE_METADATA_CLEANUP_BATCH_SIZE#3478
dimas-b merged 1 commit intoapache:mainfrom
dimas-b:metadata-batch-config

Conversation

@dimas-b
Copy link
Contributor

@dimas-b dimas-b commented Jan 19, 2026

Add a typed FeatureConfiguration with the same config name and default value.

Checklist

  • 🛡️ Don't disclose security issues! (contact security@apache.org)
  • 🔗 Clearly explained why the changes are needed, or linked related issues: Fixes #
  • 🧪 Added/updated tests with good coverage, or manually tested (and explained how)
  • 💡 Added comments for complex logic
  • 🧾 Updated CHANGELOG.md (if needed)
  • 📚 Updated documentation in site/content/in-dev/unreleased (if needed)

Add a typed `FeatureConfiguration` with the same config name and default value.
@dimas-b dimas-b force-pushed the metadata-batch-config branch from 4121268 to da96fef Compare January 19, 2026 18:27
@MonkeyCanCode
Copy link
Contributor

@github-project-automation github-project-automation bot moved this from PRs In Progress to Ready to merge in Basic Kanban Board Jan 20, 2026
@dimas-b
Copy link
Contributor Author

dimas-b commented Jan 20, 2026

@MonkeyCanCode : I'd like to update config doc, but TBH, I'm not completely up-to-date on the purpose and intricacies of this config property. It used to be hidden before. This PR is merely a technical refactoring to use a type-safe getter for this config... Would you mind skipping the doc update for now? If someone more knowledgeable in the related code wanted to update the docs, I'd welcome that :)

@MonkeyCanCode
Copy link
Contributor

@MonkeyCanCode : I'd like to update config doc, but TBH, I'm not completely up-to-date on the purpose and intricacies of this config property. It used to be hidden before. This PR is merely a technical refactoring to use a type-safe getter for this config... Would you mind skipping the doc update for now? If someone more knowledgeable in the related code wanted to update the docs, I'd welcome that :)

Sounds good. I will check these a bit later then update the doc accordingly. We did one round of this earlier as there were handful of missing configs.

@dimas-b dimas-b merged commit 0b54f70 into apache:main Jan 20, 2026
15 checks passed
@dimas-b dimas-b deleted the metadata-batch-config branch January 20, 2026 18:21
@github-project-automation github-project-automation bot moved this from Ready to merge to Done in Basic Kanban Board Jan 20, 2026
evindj pushed a commit to evindj/polaris that referenced this pull request Jan 26, 2026
Add a typed `FeatureConfiguration` with the same config name and default value.
snazy added a commit to snazy/polaris that referenced this pull request Feb 11, 2026
* Use injected RealmConfig in JdbcMetaStoreManagerFactory (apache#3412)

* Use injected RealmConfig in JdbcMetaStoreManagerFactory

* Improve code isolation by using `RealmConfig` (like most other code)
  instead of the lower-level `PolarisConfigurationStore`

* This also enabled proper CDI request-scoped injection in concert with apache#3411

* Additionally, this enables further code cleanup in `PolarisConfigurationStore`
  as discussed in apache#3324 with the goal of using this interface for the backend
  configuration code, while `RealmConfig` becomes the corresponding frontend
  interface.

* Fix `ServiceProducers.realmConfig()` to make a `RealmConfigImpl` directly from
  its dependencies (not from `CallContext`) to avoid cycles in CDI.

* Fix renovate syntax (apache#3471)

* Remove client_id, client_secret regex/pattern validation on reset endpoint call (apache#3276)

client_id/client_secret patterns are validated when calling reset endpoint but the pattern is hardcoded which can be too rigid.

* Use typed config for `TABLE_METADATA_CLEANUP_BATCH_SIZE` (apache#3478)

Add a typed `FeatureConfiguration` with the same config name and default value.

* chore(deps): update docker.io/adobe/s3mock docker tag to v4.11.0 (apache#3492)

* fix(deps): update dependency io.smallrye.config:smallrye-config-core to v3.15.1 (apache#3490)

* fix(deps): update dependency ch.qos.logback:logback-classic to v1.5.25 (apache#3489)

* chore(deps): update plugin com.gradle.develocity to v4.3.1 (apache#3452)

* Last merged commit 738bce9

---------

Co-authored-by: Dmitri Bourlatchkov <dmitri.bourlatchkov@gmail.com>
Co-authored-by: Yong Zheng <yongzheng0809@gmail.com>
Co-authored-by: Romain Manni-Bucau <rmannibucau@gmail.com>
Co-authored-by: Mend Renovate <bot@renovateapp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants