Skip to content

Use typed config for POLARIS_TASK_TIMEOUT_MILLIS #3477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dimas-b merged 1 commit into from
Jan 23, 2026
Merged

Use typed config for POLARIS_TASK_TIMEOUT_MILLIS #3477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ...e/src/main/java/org/apache/polaris/persistence/nosql/metastore/NoSqlMetaStoreManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
import java.util.function.Supplier;
import org.apache.polaris.core.PolarisCallContext;
import org.apache.polaris.core.auth.PolarisPrincipal;
import org.apache.polaris.core.config.FeatureConfiguration;
import org.apache.polaris.core.entity.LocationBasedEntity;
import org.apache.polaris.core.entity.PolarisBaseEntity;
import org.apache.polaris.core.entity.PolarisEntity;
Expand Down Expand Up @@ -555,9 +556,7 @@ public EntitiesResult loadTasks(
long taskAgeTimeout =
callCtx
.getRealmConfig()
.getConfig(
PolarisTaskConstants.TASK_TIMEOUT_MILLIS_CONFIG,
PolarisTaskConstants.TASK_TIMEOUT_MILLIS);
.getConfig(FeatureConfiguration.POLARIS_TASK_TIMEOUT_MILLIS);
return taskState == null
|| taskState.executor == null
|| clock.millis() - taskState.lastAttemptStartTime > taskAgeTimeout;
Expand Down
8 changes: 8 additions & 0 deletions polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,14 @@ public static void enforceFeatureEnabledOrThrow(
.defaultValue(true)
.buildFeatureConfiguration();

public static final FeatureConfiguration<Long> POLARIS_TASK_TIMEOUT_MILLIS =
PolarisConfiguration.<Long>builder()
.key("POLARIS_TASK_TIMEOUT_MILLIS")
.description(
"Polaris task expiry timeout (milliseconds). Older unfinished tasks may not be processed.")
.defaultValue(300_000L)
.buildFeatureConfiguration();

public static final FeatureConfiguration<Integer> STORAGE_CREDENTIAL_DURATION_SECONDS =
PolarisConfiguration.<Integer>builder()
.key("STORAGE_CREDENTIAL_DURATION_SECONDS")
Expand Down
12 changes: 12 additions & 0 deletions polaris-core/src/main/java/org/apache/polaris/core/entity/PolarisTaskConstants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,22 @@
*/
package org.apache.polaris.core.entity;

import org.apache.polaris.core.config.FeatureConfiguration;

/** Constants used to store task properties and configuration parameters */
public class PolarisTaskConstants {
/**
* @deprecated Use {@link FeatureConfiguration#POLARIS_TASK_TIMEOUT_MILLIS}
*/
@Deprecated(forRemoval = true)
public static final long TASK_TIMEOUT_MILLIS = 300000;

/**
* @deprecated Use {@link FeatureConfiguration#POLARIS_TASK_TIMEOUT_MILLIS}
*/
@Deprecated(forRemoval = true)
public static final String TASK_TIMEOUT_MILLIS_CONFIG = "POLARIS_TASK_TIMEOUT_MILLIS";

public static final String LAST_ATTEMPT_EXECUTOR_ID = "lastAttemptExecutorId";
public static final String LAST_ATTEMPT_START_TIME = "lastAttemptStartTime";
public static final String ATTEMPT_COUNT = "attemptCount";
Expand Down
4 changes: 1 addition & 3 deletions ...re/src/main/java/org/apache/polaris/core/persistence/AtomicOperationMetaStoreManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1536,9 +1536,7 @@ public void deletePrincipalSecrets(
long taskAgeTimeout =
callCtx
.getRealmConfig()
.getConfig(
PolarisTaskConstants.TASK_TIMEOUT_MILLIS_CONFIG,
PolarisTaskConstants.TASK_TIMEOUT_MILLIS);
.getConfig(FeatureConfiguration.POLARIS_TASK_TIMEOUT_MILLIS);
return taskState == null
|| taskState.executor == null
|| clock.millis() - taskState.lastAttemptStartTime > taskAgeTimeout;
Expand Down
4 changes: 1 addition & 3 deletions .../org/apache/polaris/core/persistence/transactional/TransactionalMetaStoreManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2033,9 +2033,7 @@ private PolarisEntityResolver resolveSecurableToRoleGrant(
long taskAgeTimeout =
callCtx
.getRealmConfig()
.getConfig(
PolarisTaskConstants.TASK_TIMEOUT_MILLIS_CONFIG,
PolarisTaskConstants.TASK_TIMEOUT_MILLIS);
.getConfig(FeatureConfiguration.POLARIS_TASK_TIMEOUT_MILLIS);
return taskState == null
|| taskState.executor == null
|| clock.millis() - taskState.lastAttemptStartTime > taskAgeTimeout;
Expand Down