Require approval from 2 reviewers before merging

[jbonofre]

No description provided.

[evindj]

as per agreement in the discussion thread.

[singhpk234]

I think this is unfortunate but this is must required now specially
after repeated occurence :
1/ #3207 (comment)
2/#3268 (comment)

[jbonofre]

@flyrain no objection from you about this one ? It seems we have already a consensus from several contributors.

[flyrain]

To carry on my thoughts on the dev mailing discussion, I don't think enforcing 2 reviewers on PRs solves the problem, meanwhile it can slow down the review process, esp. on trivial PRs. But I will not block it if people want to give it a try.

[jbonofre]

@flyrain I got your point. I'm not hard pushing for this one, but more as an attempt to involve more reviewers.

@adutra @MonkeyCanCode @singhpk234 @dimas-b @evindj @adam-christian-software what do you guys think ? Should we try this ?

I'm fine to close this PR if you think it won't help (I'm not very convinced either 😄 ).

[snazy]

(Casting my objection on the dev-ML discussion here:)
Not really a fan of having a hard technical requirement of two approvals for every little PR.

[jbonofre]

OK, so, we don't have consensus. Let's close this one, we can revisit later if needed.

[adutra]

For posterity I'm with @flyrain here: I don't really think 2 reviewers solves the original issue, but I wouldn't oppose the idea either.