Skip to content

Deprecate untyped RealmConfig.getConfig() #3323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dimas-b merged 1 commit into from
Jan 5, 2026
Merged

Deprecate untyped RealmConfig.getConfig() #3323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions polaris-core/src/main/java/org/apache/polaris/core/config/RealmConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@ public interface RealmConfig {
* @param <T> the type of the configuration value
* @param configName the name of the configuration key to check
* @return the current value set for the configuration key, or null if not set
* @deprecated Use typed {@link #getConfig(PolarisConfiguration)} instead.
Copy link
Contributor

@singhpk234 singhpk234 Dec 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have a version in mind, where were wanna remove it, if we do it would be nice to add it here !

Copy link
Contributor Author

@dimas-b dimas-b Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally do not have a preference for a specific Polaris version where this can be removed, but open to suggestions :)

*/
@Deprecated
<T> @Nullable T getConfig(String configName);

/**
Expand Down
3 changes: 2 additions & 1 deletion runtime/service/src/main/java/org/apache/polaris/service/catalog/common/CatalogUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import org.apache.iceberg.catalog.TableIdentifier;
import org.apache.iceberg.exceptions.ForbiddenException;
import org.apache.polaris.core.admin.model.StorageConfigInfo;
import org.apache.polaris.core.config.FeatureConfiguration;
import org.apache.polaris.core.config.RealmConfig;
import org.apache.polaris.core.entity.PolarisEntitySubType;
import org.apache.polaris.core.entity.PolarisEntityType;
Expand Down Expand Up @@ -77,7 +78,7 @@ public static void validateLocationsForTableLike(
restrictions -> restrictions.validate(realmConfig, identifier, locations),
() -> {
List<String> allowedStorageTypes =
realmConfig.getConfig("SUPPORTED_CATALOG_STORAGE_TYPES");
realmConfig.getConfig(FeatureConfiguration.SUPPORTED_CATALOG_STORAGE_TYPES);
if (allowedStorageTypes != null
&& !allowedStorageTypes.contains(StorageConfigInfo.StorageTypeEnum.FILE.name())) {
List<String> invalidLocations =
Expand Down