Skip to content

Testing: increase visibility + make PCC/PMSM accessible #3137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snazy merged 1 commit into from
Dec 2, 2025
Merged

Testing: increase visibility + make PCC/PMSM accessible #3137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...estFixtures/java/org/apache/polaris/core/persistence/BasePolarisMetaStoreManagerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ public abstract class BasePolarisMetaStoreManagerTest {

protected final MutableClock clock = MutableClock.of(Instant.now(), ZoneOffset.UTC);

private PolarisTestMetaStoreManager polarisTestMetaStoreManager;
protected PolarisTestMetaStoreManager polarisTestMetaStoreManager;
Copy link
Contributor

@dimas-b dimas-b Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not add an accessible getter/setter instead?

Copy link
Member Author

@snazy snazy Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it an issue for test code?

Copy link
Contributor

@dimas-b dimas-b Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously this class is meant to be extended. Direct field access is generally harder to refactor later, IMHO.

Copy link
Contributor

@dimas-b dimas-b Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, the scope of this class is probably limited to Polaris' code inside this repo, so it's not a concern


@BeforeEach
public void setupPolarisMetaStoreManager() {
Expand Down
8 changes: 8 additions & 0 deletions ...rc/testFixtures/java/org/apache/polaris/core/persistence/PolarisTestMetaStoreManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,14 @@ public PolarisTestMetaStoreManager(
this.doRetry = false;
}

public PolarisCallContext polarisCallContext() {
return polarisCallContext;
}

public PolarisMetaStoreManager polarisMetaStoreManager() {
return polarisMetaStoreManager;
}

public void forceRetry() {
this.doRetry = true;
}
Expand Down
6 changes: 3 additions & 3 deletions ...ime/service/src/intTest/java/org/apache/polaris/service/it/PolarisRestCatalogMinIOIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@
@ExtendWith(PolarisIntegrationTestExtension.class)
public class PolarisRestCatalogMinIOIT extends PolarisRestCatalogIntegrationBase {

private static final String BUCKET_URI_PREFIX = "/minio-test-polaris";
private static final String MINIO_ACCESS_KEY = "test-ak-123-polaris";
private static final String MINIO_SECRET_KEY = "test-sk-123-polaris";
protected static final String BUCKET_URI_PREFIX = "/minio-test-polaris";
protected static final String MINIO_ACCESS_KEY = "test-ak-123-polaris";
protected static final String MINIO_SECRET_KEY = "test-sk-123-polaris";

public static class Profile implements QuarkusTestProfile {

Expand Down