NoSQL: CDI / Quarkus #3135

snazy · 2025-11-24T08:33:45Z

Adds the Quarkus/CDI code handling Quarkus specifics.

dimas-b · 2025-11-24T17:41:31Z

...rc/main/java/org/apache/polaris/persistence/nosql/quarkus/backend/MongoDbBackendBuilder.java

+
+@BackendType(MongoDbBackendFactory.NAME)
+@Dependent
+class MongoDbBackendBuilder implements BackendBuilder {


Would it be possible to (re-)structure CDI objects in a way that will not mix multiple backends in the same general-purpose module?

I imagine when new backends are added, it would be preferable to keep their code isolated in their respective modules as much as possible.

In other words, is it possible to build a server with classes from just one particular backend implementation present on the class path?

Sure, we can add quarkus-specific modules next to every backend. But that's way more work at this point.

Fair enough.

persistence/nosql/persistence/cdi/quarkus/build.gradle.kts

dimas-b · 2025-11-24T17:56:32Z

LICENSE

 * helm/polaris/templates/servicemonitor.yaml
 * helm/polaris/templates/storage.yaml

+Code underneath the components/persistence directory, especially pluggable object types, index related, cache,


components/persistence does not exist in the current main 🤔 Shall we list individual files (as above)?

@jbonofre : WDYT?

Hard to name "individual files", as it's only inspired. But I see this causes confusion. Removing this from the PR.

...rkus/src/main/java/org/apache/polaris/persistence/nosql/quarkus/backend/BackendProvider.java

...kus/src/main/java/org/apache/polaris/persistence/nosql/quarkus/backend/ObservingBackend.java

dimas-b

LGTM. I propose to merge with existing config names for reasons I highlighted on the specific comment thread in this PR. If people think this is a major concern, let's move that discussion to the dev ML.

flyrain · 2025-11-27T18:28:03Z

let's move that discussion to the dev ML.

+1, let move the discussion to ML

dimas-b · 2025-11-27T18:53:38Z

dev ML: https://lists.apache.org/thread/vmdpb45j1nmmlhswz7fm87gxgoldmr28

dimas-b · 2025-12-03T15:07:17Z

persistence/nosql/persistence/correctness/README.md

-  -Dpolaris.persistence.backend=MongoDb \
-  -Dpolaris.persistence.backend.mongodb.uri=mongodb://localhost:27017/test
-  -Dpolaris.persistence.backend.mongodb.databaseName=polaris_mongo_test
+  -Dpolaris.persistence.nosql=MongoDb \


polaris.persistence.nosql.backend=...?

dimas-b

My comment about the README file is non-blocking (can be fixed later)

singhpk234

LGTM, thanks @snazy !

singhpk234 · 2025-12-04T02:12:38Z

...kus/src/main/java/org/apache/polaris/persistence/nosql/quarkus/backend/ObservingBackend.java

+@ApplicationScoped
+@Default
+public class ObservingBackend implements Backend {
+  public static final String TELEMETRY_PREFIX = "polaris.persistence.nosql";


nit / optional : may be we can include . in prefix polaris.persistence.nosql.

@adnanhemani

* Do not fail a release when markdown-link-check check fails as it is flaky (apache#3116) * Source tarball reproducible (apache#3143) `git --mtime` MUST use the time zone for reproducible builds. * Skip release e-mail templates from svn dist copy (apache#3147) * Make pom.xml always reproducible (apache#3145) It turned out in practice, that there's no guarantee that the `<parent>` element in `pom.xml` files always appear at the same place. This change ensures that the `<parent>` elements always appears at a deterministic location at the top of `pom.xml` files. * Fix executable POSIX permission in archive files (apache#3146) The PR apache#2819 accidentally _removed_ the executable POSIX file permission, assuming that not explicity setting the attributes via `filePermissions` retains the file-system 'x' permission. This change updates the logic to explicitly check the owner-executable bit and uses `755` or `644` respectively for each individual file in the archive. * Spark: Initial integration for hudi tables within Polaris (apache#1862) * Update actions/setup-python digest to 83679a8 (apache#3157) * Update actions/stale digest to 5611b9d (apache#3155) * Fix LICENSE and NOTICE in the distributions and docker images. (apache#3125) * Remove readEntity() call (apache#3111) Calling readEntity() is not allowed server-side by some HTTP servers. * Run CI on release branches (apache#3121) The release workflows check whether CI passes for the required checks. This would fail, because CI isn't configured to run on release branches. This change lets CI run on `release/*` branches. * adding support to use a kms key for s3 buckets data encryption (AWS only) (apache#2802) Add catalog-level support for KMS with s3 buckets * Update plugin jetbrains-changelog to v2.5.0 (apache#3166) * Update quay.io/keycloak/keycloak Docker tag to v26.4.6 (apache#3163) * NoSQL: Prepare admin-tool (apache#3134) No functional changes. 1. Refactor the configuration property to a configuration type. 2. Make `BaseCommand` suitable for non-meta-store-factory use cases. * Iceberg-Catalog: also set catalog-id for location overlap checks (apache#3136) * Fix catalog-role creating in `PolarisTestMetaStoreManager` (apache#3122) `testLookup()` attempts to check for a catalog-role on catalog ID 0, which is an illegal ID for a catalog. Fix is to move the assertion below the catalog creation. * Releasy: prepare for Helm 4 (helm package repro) (apache#3088) Part of apache#3086 * Update Quarkus Platform and Group to v3.30.1 (apache#3168) * Relax ARN validation logic (apache#3071) Following up on apache#3005, which allowed a wide range of ARN values in the validation RegEx, remove an additional explicit check for `aws-cn` being present in the ARN as a sub-string. Update existing unit tests to process `aws-cn` ARNs as common `aws` ARNs. Note: the old validation code does not look correct because it used to check for `aws-cn` anywhere in the ARN string, not just in its "partition" component. * docs: Add François as Mentor (apache#3162) * docs: Add François as Mentor * update mentor list according to ASF project info * Event type IDs + event metadata incl. OTel context (apache#2998) This PR implements the action items from the following discussion threads: - https://lists.apache.org/thread/yx7pkgczl6k7bt4k4yzqrrq9gn7gqk2p - https://lists.apache.org/thread/rl5cpcft16sn5n00mfkmx9ldn3gsqtfy - https://lists.apache.org/thread/5dpyo0nn2jbnjtkgv0rm1dz8mpt132j9 Summary of changes: - Introduced a `PolarisEventType` enum holding the 150+ event types. - Introduced a `PolarisEventMetadata` interface as suggested by @adnanhemani, exposing: event ID, timestamp, realm ID, principal, request ID, and OTel context. - Introduced a `PolarisEventMetadataFactory` to centralize the logic for gathering the various elements of an event metadata. - Modified `PolarisEvent` to expose 3 new methods: - `PolarisEventType type()` - `PolarisEventMetadata metadata()` - Persistence of OTel context is done in `additional_properties` as suggested by @flyrain. - Added `InMemoryBufferEventListenerIntegrationTest` to verify that all contextual data is properly persisted. * fix typo in management API yaml (apache#3172) * Fix homepage Get Started button layout (apache#3169) Wrap the Get Started button in a div container to prevent it from becoming inline with text at certain screen widths. Follows Docsy blocks/cover shortcode pattern. * fix OPA javadoc referencing `OpaSchemaGenerator` (apache#3153) `OpaSchemaGenerator` is not on the classpath of `opa/impl/main` so the javadoc tool is not able to resolve a `@link` to it. Use `@code` instead to avoid build warnings like the following: * Update dependency com.azure:azure-sdk-bom to v1.3.3 (apache#3179) * Update dependency com.google.errorprone:error_prone_core to v2.45.0 (apache#3177) * test: Add Some Spark Client Tests and Update Documentation on Generic Tables (apache#3152) * Site: Make homepage image full-width (apache#3171) Add CSS class to allow images to span full viewport width by canceling out container padding. Apply to homepage hero image using AsciiDoc role attribute. * chore(enhancement): gitignore application-local.properties (apache#3175) * Update registry.access.redhat.com/ubi9/openjdk-21-runtime Docker tag to v1.23-6.1764155306 (apache#3186) * Update quay.io/keycloak/keycloak Docker tag to v26.4.7 (apache#3185) * Update dependency software.amazon.awssdk:bom to v2.39.6 (apache#3184) * Testing: increase visibility + make PCC/PMSM accessible (apache#3137) * `BasePolarisMetaStoreManagerTest`: make `PolarisCallContext` + `PolarisMetaStoreManager` + `PolarisTestMetaStoreManager` accessible by subclasses * Make constants of `PolarisRestCatalogMinIOIT` accessible * Update docker.io/prom/prometheus Docker tag to v3.8.0 (apache#3191) * Update helm/chart-testing-action action to v2.8.0 (apache#2982) * chore(enhancement): make custom hidden tasks visible in ./gradlew tasks (apache#3176) * fix type cast warning in PolarisCatalogUtils (apache#3178) ``` plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/utils/PolarisCatalogUtils.java:131: warning: [unchecked] unchecked cast scala.collection.immutable.Map$.MODULE$.apply( ^ required: Map<String,String> found: Map ``` * chore(deps): update actions/stale digest to 9971854 (apache#3197) * fix(deps): update dependency io.smallrye:jandex to v3.5.3 (apache#3193) * chore(deps): update actions/checkout digest to 8e8c483 (apache#3192) * added venv to the gitignore (apache#3199) * CLI: Add Hive federation option (apache#2798) * chore(deps): update docker.io/jaegertracing/all-in-one docker tag to v1.76.0 (apache#3201) * chore(deps): update registry.access.redhat.com/ubi9/openjdk-21-runtime docker tag to v1.23-6.1764562148 (apache#3202) * fix(deps): update quarkus platform and group to v3.30.2 (apache#3198) * chore(deps): update dependency boto3 to ~=1.42.2 (apache#3126) * NoSQL: CDI / Quarkus (apache#3135) * fix(deps): update dependency com.adobe.testing:s3mock-testcontainers to v4.11.0 (apache#3208) * Update dependency mypy to >=1.19, <=1.19.0 (apache#3180) * chore(deps): update actions/setup-java digest to f2beeb2 (apache#3206) * Fix spelling in comments (apache#3212) * Make each task attempt run in a dedicated CDI request context (apache#3210) * Make each task attempt run in a dedicated CDI request context Currently, tasks inherit the CDI context from the requests that submitted them, but run asynchronously. Therefore, if the original request context ends, the task may not be able to use the expired beans for that context. This change makes each task run in its own dedicated CDI request context with `RealmContext` explicitly propagated in `TaskExecutorImpl`. Test-only error handlers are added to `TaskExecutorImpl` to facilitate detecting task errors during CI. Fixes apache#3203 * fix(deps): update dependency com.gradleup.shadow:shadow-gradle-plugin to v9.3.0 (apache#3218) * Last merged commit be3c88b --------- Co-authored-by: Pierre Laporte <[email protected]> Co-authored-by: Rahil C <[email protected]> Co-authored-by: Mend Renovate <[email protected]> Co-authored-by: JB Onofré <[email protected]> Co-authored-by: Alexandre Dutra <[email protected]> Co-authored-by: fabio-rizzo-01 <[email protected]> Co-authored-by: Dmitri Bourlatchkov <[email protected]> Co-authored-by: Tamas Mate <[email protected]> Co-authored-by: Adam Christian <[email protected]> Co-authored-by: Artur Rakhmatulin <[email protected]> Co-authored-by: cccs-cat001 <[email protected]> Co-authored-by: Yufei Gu <[email protected]> Co-authored-by: Yong Zheng <[email protected]>

NoSQL: CDI / Quarkus

c2d7ea9

github-project-automation bot added this to Basic Kanban Board Nov 24, 2025

github-project-automation bot moved this to PRs In Progress in Basic Kanban Board Nov 24, 2025

dimas-b reviewed Nov 24, 2025

View reviewed changes

singhpk234 reviewed Nov 25, 2025

View reviewed changes

...rkus/src/main/java/org/apache/polaris/persistence/nosql/quarkus/backend/BackendProvider.java Outdated Show resolved Hide resolved

...kus/src/main/java/org/apache/polaris/persistence/nosql/quarkus/backend/ObservingBackend.java Outdated Show resolved Hide resolved

snazy added 2 commits November 26, 2025 08:31

revert LICENSE change

aaaed56

telemetry prefix

2ad1648

dimas-b previously approved these changes Nov 27, 2025

View reviewed changes

github-project-automation bot moved this from PRs In Progress to Ready to merge in Basic Kanban Board Nov 27, 2025

snazy added 2 commits December 3, 2025 10:43

cfg rename previous

d120c17

cfg rename Quarkus

3402ff2

snazy dismissed dimas-b’s stale review via 3402ff2 December 3, 2025 10:38

dimas-b reviewed Dec 3, 2025

View reviewed changes

dimas-b approved these changes Dec 3, 2025

View reviewed changes

singhpk234 approved these changes Dec 4, 2025

View reviewed changes

snazy merged commit f5224fe into apache:main Dec 4, 2025
15 checks passed

github-project-automation bot moved this from Ready to merge to Done in Basic Kanban Board Dec 4, 2025

snazy deleted the nosql-cdi-quarkus branch December 4, 2025 05:56

This was referenced Dec 8, 2025

NoSQL: Add metastore types and mappings #3207

Merged

NoSQL: Metastore maintenance #3268

Merged

NoSQL: CDI / Quarkus #3135

NoSQL: CDI / Quarkus #3135

Uh oh!

Conversation

snazy commented Nov 24, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dimas-b left a comment

Choose a reason for hiding this comment

Uh oh!

flyrain commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dimas-b commented Nov 27, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dimas-b left a comment

Choose a reason for hiding this comment

Uh oh!

singhpk234 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

flyrain commented Nov 27, 2025 •

edited

Loading