-
Notifications
You must be signed in to change notification settings - Fork 362
Add eclipseLinkDeps options for Dockerfile and run.sh #313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
aihuaxu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
Hi @MonkeyCanCode, can you rebase for the conflict? |
README.md
Outdated
| - `./run.sh` - To run Polaris as a mini-deployment locally. This will create one pod that bind itself to ports `8181` and `8182`. | ||
| - Optional run options: | ||
| - `./run.sh -b "ECLIPSELINK=true"` - Enables the EclipseLink extension. | ||
| - `./run.sh -b "ECLIPSELINK=true;ECLIPSELINK_DEPS=[groupId]:[artifactId]:[version],..."` – Enabled the EclipseLink extension with one or more additional dependencies for EclipseLink (e.g., JDBC drivers), separated by commas. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's semicolons not commas right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The deps for ECLIPSELINK_DEPS but the diff options are separated by commas. So following format:
-b "KEY1=V1;KEY2=V2,V3,V4;KEY3=v4"
This is because the delimiter is comma for diff optional options. Thus, I can't use comma to split deps as well.
|
Thanks @MonkeyCanCode for the PR. Thanks @eric-maynard @aihuaxu for the review. |
Description
This is a follow up PR based on #227 where additional document as well as new optional build argument (
ECLIPSELINK_DEPS) forDockerfileandrun.sh.I saw #311 already added the additional option for
Dockerfile, so I ended up using that change as well.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested build options on
Dockerfile:Tested build options on
run.sh:Checklist:
Please delete options that are not relevant.